From: Anton Khirnov <anton@khirnov.net>
Subject: Re: [PATCH] lib/message-file: plug three memleaks.
To: notmuch@notmuchmail.org
In-Reply-To: <1302878638-17634-1-git-send-email-anton@khirnov.net>
References: <1302878638-17634-1-git-send-email-anton@khirnov.net>
Date: Mon, 09 May 2011 08:46:44 +0200
Message-Id: <20110509064645.2B6AD7F508@zohar.localdomain>
Precedence: list

On Fri, 15 Apr 2011 16:43:58 +0200, Anton Khirnov <anton@khirnov.net> wrote:
> ---
>  lib/message-file.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/message-file.c b/lib/message-file.c
> index 7722832..b7b3286 100644
> --- a/lib/message-file.c
> +++ b/lib/message-file.c
> @@ -341,12 +341,17 @@ notmuch_message_file_get_header (notmuch_message_file_t *message,
>  		strncpy(combined_header,header_sofar,hdrsofar);
>  		*(combined_header+hdrsofar) = ' ';
>  		strncpy(combined_header+hdrsofar+1,decoded_value,newhdr+1);
> +		free(decoded_value);
>  		g_hash_table_insert (message->headers, header, combined_header);
>  	    }
>  	} else {
>  	    if (header_sofar == NULL) {
>  		/* Only insert if we don't have a value for this header, yet. */
>  		g_hash_table_insert (message->headers, header, decoded_value);
> +	    } else {
> +		free(header);
> +		free(decoded_value);
> +		decoded_value = header_sofar;
>  	    }
>  	}
>  	/* if we found a match we can bail - unless of course we are
> -- 
> 1.7.4.1
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

ping

--
Anton Khirnov