Date: Sun, 22 Nov 2009 12:57:09 +0200
Message-ID: <87vdh2n7y2.wl%djcb@djcbsoftware.nl>
From: Dirk-Jan C. Binnema <djcb.bulk@gmail.com>
To: Michiel Buddingh' <michiel@michielbuddingh.net>
In-Reply-To: <9bfdedddeab9c58cd45d8d448323d0fc@localhost>
References: <87fx8bygi7.fsf@linux.vnet.ibm.com>
	<87bpiv4t9h.fsf@yoom.home.cworth.org>
	<87y6lz39nd.fsf@yoom.home.cworth.org>
	<20091121221207.GB17268@jukie.net>
	<9cce5525b093b87fe74d427954ffad89@localhost>
	<87d43b2oif.fsf@yoom.home.cworth.org>
	<9bfdedddeab9c58cd45d8d448323d0fc@localhost>
Mail-Reply-To: djcb@djcbsoftware.nl
User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/23.1 Mule/6.0
	(HANACHIRUSATO)
Organization: DJCBSoftware
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] notmuch: Add Maildir directory name as tag
	name for messages
Precedence: list
Reply-To: djcb@djcbsoftware.nl

Hi Michiel,

>>>>> "Michiel" == Michiel Buddingh' <michiel@michielbuddingh.net> writes:

    Michiel> Another thing; notmuch currently indexes by message-id (or SHA-1
    Michiel> hash if that is not present).  Maildir, on the other hand, uses
    Michiel> file names as stable (when stripped of the parts trailing the
    Michiel> colon) unique (knock on wood) identifiers.  A Maildir-aware
    Michiel> notmuch could incorporate this to be far more resistant to bulk
    Michiel> mail moves done by other clients, by using filename lookups to
    Michiel> avoid accessing and parsing the mail files themselves.

I think that is a good idea.
    
    Michiel> I should re-iterate that I'm new to notmuch, and it's obvious
    Michiel> that I'm trying to beat it into becoming something it was never
    Michiel> intended to be; on the other hand, I'd like people to chime in on
    Michiel> this.

I'm new here too, so please be gentle as I learn how things work....
    
    Michiel> +
    Michiel> +static void
    Michiel> +derive_tags_from_maildir_flags (notmuch_message_t *message, const char *
    Michiel> path)

I see you don't handle the "N" -- is that deliberate? Also, a minor addition
may to also allow for '!' instead of ':' as a separator, as that's the
semi-official way to use Maildirs on (V)FAT filesystems (which don't allow for
colons in filenames).


Best wishes,
Dirk.


-- 
Dirk-Jan C. Binnema                  Helsinki, Finland
e:djcb@djcbsoftware.nl           w:www.djcbsoftware.nl
pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C