Return-Path: <james.vasile@opensourcematters.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 4496F431FD0
	for <notmuch@notmuchmail.org>; Tue, 15 Mar 2011 12:01:28 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.363
X-Spam-Level: 
X-Spam-Status: No, score=0.363 tagged_above=-999 required=5
	tests=[RDNS_DYNAMIC=0.363] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id k7tKr-OmHegb for <notmuch@notmuchmail.org>;
	Tue, 15 Mar 2011 12:01:26 -0700 (PDT)
Received: from hackervisions.org (67-207-143-141.slicehost.net
	[67.207.143.141]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 52E0C431FB5
	for <notmuch@notmuchmail.org>; Tue, 15 Mar 2011 12:01:26 -0700 (PDT)
Received: from thurgood-marshall.sflc.info ([216.27.154.194] helo=localhost)
	by hackervisions.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72) (envelope-from <james.vasile@opensourcematters.org>)
	id 1PzZUh-0007q2-Gb; Tue, 15 Mar 2011 15:01:23 -0400
From: James Vasile <james@hackervisions.org>
To: Jameson Rollins <jrollins@finestructure.net>,
	Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: python documentation
In-Reply-To: <87r5a8xmhc.fsf@servo.finestructure.net>
References: <87hbb4zyp6.fsf@servo.finestructure.net>
	<87pqpsh0sg.fsf@SSpaeth.de> <87y64gjla8.fsf@opensourcematters.org>
	<87r5a8xmhc.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.5-212-g1afb373 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 15 Mar 2011 15:01:15 -0400
Message-ID: <87vczkjjic.fsf@opensourcematters.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2011 19:01:28 -0000

On Tue, 15 Mar 2011 11:33:19 -0700, Jameson Rollins <jrollins@finestructure.net> wrote:
> On Tue, 15 Mar 2011 14:22:55 -0400, James Vasile <james@hackervisions.org> wrote:
> > notmuch dump includes '# TODO: implement "dump <filename>"' but it
> > appears to work already.  What's missing?
> 
> Hey, James.  Is this related to the python documentation somehow?  If
> so, I'm not sure how.
> 
> If you're just referencing a completed TODO, you could definitely submit
> a patch to remove it from the TODO.
> 

Yep, just a completed TODO.  Patch below.

diff --git a/bindings/python/notmuch.py b/bindings/python/notmuch.py
index 8572612..8d11859 100755
--- a/bindings/python/notmuch.py
+++ b/bindings/python/notmuch.py
@@ -486,7 +486,6 @@ def main():
             print "\n".join([t for t in msgs.collect_tags()])
     #-------------------------------------
     elif sys.argv[1] == 'dump':
-        # TODO: implement "dump <filename>"
         if len(sys.argv) == 2:
             f = sys.stdout
         else: