Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 96B86431FAF for ; Thu, 17 May 2012 12:09:30 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dh8H9tC4TvhE for ; Thu, 17 May 2012 12:09:29 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 4907C431FAE for ; Thu, 17 May 2012 12:09:29 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 1AB9D100639; Thu, 17 May 2012 22:09:36 +0300 (EEST) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] NEWS: Insert markdown formatting commands in 0.13 section text In-Reply-To: <87boln639t.fsf@zancas.localnet> References: <1337146745-21525-1-git-send-email-tomi.ollila@iki.fi> <87boln639t.fsf@zancas.localnet> User-Agent: Notmuch/0.13~rc1+23~gefd2384 (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2012 19:09:30 -0000 On Thu, May 17 2012, David Bremner wrote: > Tomi Ollila writes: >> >> id:"1337152910-22371-4-git-send-email-tomi.ollila@iki.fi" >> id:"1337152910-22371-5-git-send-email-tomi.ollila@iki.fi" >> id:"1337152910-22371-6-git-send-email-tomi.ollila@iki.fi" >> id:"1337152910-22371-7-git-send-email-tomi.ollila@iki.fi" > > I pushed those to release. I'll merge them to master after a bit; > hopefully we'll figure out that reply encoding thing and do a bug fix > release. I got it working by doing this: --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 7fa441a..7523bb6 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -244,7 +244,9 @@ the given type." current buffer, if possible." (let ((display-buffer (current-buffer))) (with-temp-buffer - (let* ((charset (plist-get part :content-charset)) + ;; (let* ((charset (or (plist-get part :content-charset) "utf-8")) + ;; (let* ((charset (or (plist-get part :content-charset) "latin-1")) + (let* ((charset (or (plist-get part :content-charset) 'gnus-decoded)) (handle (mm-make-handle (current-buffer) `(,content-type (charset . ,charset))))) ;; If the user wants the part inlined, insert the content and ;; test whether we are able to inline it (which includes both --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- (using "latin-1" also provided desired results... but with "utf-8" results were the same as with default 'nil) But, for consistency (with `notmuch show ...` handling), when content-type is "text/plain" (and as `notmuch reply --format=json` provides text/plain content inline) we should use the construct `(insert (notmuch-get-bodypart-content msg part nth ...)` to insert that content (as done before f6c170fabca8f39e74705e3813504137811bf162 and is also done in `notmuch-show-insert-part-text/plain`). If anyone is faster than me to provide patch what would be fine ;) > d Tomi