From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch v7 06/14] notmuch-restore: move query handling for batch
	restore to parser
In-Reply-To: <87wqwj8alx.fsf@qmul.ac.uk>
References: <1355492062-7546-1-git-send-email-david@tethera.net>
	<1355492062-7546-7-git-send-email-david@tethera.net>
	<87wqwj8alx.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.14+163~g11a220a (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Sat, 15 Dec 2012 14:18:23 -0400
Message-ID: <87hann5gcw.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Dec 2012 18:18:33 -0000

Mark Walters <markwalters1009@gmail.com> writes:

>> +	if (hex_decode_inplace (tok) != HEX_SUCCESS) {
>> +	    ret = line_error (TAG_PARSE_INVALID, line_for_error,
>> +			      "hex decoding of query %s failed", tok);
>> +	    goto DONE;
>> +	}
>> +	/* skip 'id:' */
>> +	*query_string = tok + 3;
>
> This looks like it doesn't double_quote the query_string in this (the
> TAG_FLAG_ID_ONLY) case. Is that deliberate?

Yes, that's what I meant by 

,----
| We also need this to avoid the query quoting for more
| general queries (to be written) that will mess up raw message-ids.
`----

perhaps it deserves a comment in the code.