Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5BB8940DEF3 for ; Fri, 19 Nov 2010 08:01:59 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3pw8iNgMR4SC for ; Fri, 19 Nov 2010 08:01:47 -0800 (PST) Received: from e28smtp04.in.ibm.com (e28smtp04.in.ibm.com [122.248.162.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4A41D40DEEB for ; Fri, 19 Nov 2010 08:01:47 -0800 (PST) Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id oAJG1ee5012182 for ; Fri, 19 Nov 2010 21:31:40 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAJG1duh3989712 for ; Fri, 19 Nov 2010 21:31:39 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAJG1csC015758 for ; Sat, 20 Nov 2010 03:01:38 +1100 Received: from skywalker.linux.vnet.ibm.com ([9.124.208.131]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oAJG1bWe015689; Sat, 20 Nov 2010 03:01:38 +1100 From: "Aneesh Kumar K. V" To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Accommodate message-mode updates. In-Reply-To: <1289929898-16287-1-git-send-email-dme@dme.org> References: <1288200417-6584-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1289929898-16287-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.4-34-gca0b4d9 (http://notmuchmail.org) Emacs/24.0.50.1 (i686-pc-linux-gnu) Date: Fri, 19 Nov 2010 21:31:36 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 16:01:59 -0000 On Tue, 16 Nov 2010 17:51:38 +0000, David Edmondson wrote: > Message mode uses a different name for composition buffers in newer > versions of emacs. Allow for this when causing the composition window > to overlay the viewing window. > --- > > I don't understand why Aneesh chose to use `add-hook' and `purecopy'. So what when i have unset mail added via .emacs even the older version will work. making sure if the name change again i can fix it by a .emacs update rather than notmuch code update. > > emacs/notmuch-mua.el | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index dc7b386..70c8dff 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -88,7 +88,7 @@ list." > (let > ;; Overlay the composition window on that being used to read > ;; the original message. > - ((same-window-regexps '("\\*mail .*"))) > + ((same-window-regexps '("\\*mail .*" "\\*unsent mail .*"))) > (notmuch-mua-mail (mail-header 'to headers) > (mail-header 'subject headers) > (message-headers-to-generate headers t '(to subject)))) -aneesh