From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,
	Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Subject: Re: [PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags
	of all messages in current buffer"
In-Reply-To: <1330122640-18895-3-git-send-email-pieter@praet.org>
References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>
	<1330122640-18895-1-git-send-email-pieter@praet.org>
	<1330122640-18895-3-git-send-email-pieter@praet.org>
User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 15 Oct 2012 22:15:30 -0400
Message-ID: <87txtv88n1.fsf@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Pieter Praet <pieter@praet.org> writes:

> * test/emacs:
>
>   New subtest "notmuch-show: change tags of all messages in current buffer":
>   `notmuch-show-tag-all' ("*") changes tags of *all* messages in current buffer.
> ---
>  test/emacs |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/test/emacs b/test/emacs
> index ec1dbb0..d2dbafc 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -136,6 +136,21 @@ test_emacs "(notmuch-show \"$os_x_darwin_thread\")
>  output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
>
> +test_begin_subtest "notmuch-show: change tags of all messages in current buffer"
> +query="$os_x_darwin_thread"
> +filter="from:Jiang"
> +add_tag="notmuch-show-tag-all"
> +del_tag="inbox"
> +count_total=$(notmuch count -- "$query")               # = 4
> +count_match=$(notmuch count -- "$query" AND "$filter") # = 2

In this test, what use is count_match? Just so that the tests' forms
are the same? Maybe you want to put an assertion that count_total !=
count_match, just for sanity's sake?

Otherwise, patches 1-3 look fine to me.

Ethan