Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2090A431FB6 for ; Fri, 6 May 2011 02:09:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i50mZnl+4R7H for ; Fri, 6 May 2011 02:09:26 -0700 (PDT) Received: from tesla.chaoflow.net (tesla.chaoflow.net [188.40.54.22]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4AAC3431FB5 for ; Fri, 6 May 2011 02:09:26 -0700 (PDT) Received: from eve.chaoflow.net (e181005131.adsl.alicedsl.de [85.181.5.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: flo@chaoflow.net) by tesla.chaoflow.net (Postfix) with ESMTPSA id 57447CD27; Fri, 6 May 2011 11:09:24 +0200 (CEST) Received: by eve.chaoflow.net (Postfix, from userid 1000) id 765C227F; Fri, 6 May 2011 09:09:23 +0000 (Local time zone must be set--see zic manual page) From: Florian Friesdorf To: jrollins@finestructure.net Subject: Re: [PATCH] create and set temporary home directory In-Reply-To: <877har5uek.fsf@eve.chaoflow.net> References: <877har5uek.fsf@eve.chaoflow.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Fri, 06 May 2011 11:09:19 +0200 Message-ID: <87hb986vr4.fsf@eve.chaoflow.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.96.5 at tesla X-Virus-Status: Clean Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 09:09:28 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable Hi Jamie, any chance of getting this patch into 0.6? It would enable me to run the tests for the nixos package without patching. You could pull it from: git://github.com/chaoflow/notmuch.git branch: for-review/test-fixes commit: d8842075b1ff6f008e60aced5f4e0b4d7ac79515 regards On Mon, 18 Apr 2011 19:41:39 +0200, Florian Friesdorf wr= ote: >=20 > My first patch send to the list, not sure whether done properly. >=20 > In the master branch in test/emacs two tests access the build users home > directory, so does emacs_deliver_message in the crypto branch. >=20 > I think the tests should not touch the build user's home directory. The > patch creates a directory in the temporary test directory and sets home > accordingly. >=20 > In case of a non-existent home directory, the tests are failing without > this patch. >=20 > --- > test/test-lib.sh | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 9581ead..43dae21 100755 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -923,6 +923,13 @@ rm -fr "$test" || { > exit 1 > } >=20=20 > +# A temporary home directory is needed by at least: > +# - emacs/"Sending a message via (fake) SMTP" > +# - emacs/"Reply within emacs" > +# - crypto/emacs_deliver_message > +export HOME=3D"${TMP_DIRECTORY}/home" > +mkdir -p "${HOME}" > + > MAIL_DIR=3D"${TMP_DIRECTORY}/mail" > export GNUPGHOME=3D"${TMP_DIRECTORY}/gnupg" > export NOTMUCH_CONFIG=3D"${TMP_DIRECTORY}/notmuch-config" > --=20 > 1.7.4.4 >=20 >=20 >=20 >=20 >=20 > --=20 > Florian Friesdorf > GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 > Jabber/XMPP: flo@chaoflow.net > IRC: chaoflow on freenode,ircnet,blafasel,OFTC > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch =2D-=20 Florian Friesdorf GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 Jabber/XMPP: flo@chaoflow.net IRC: chaoflow on freenode,ircnet,blafasel,OFTC --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAEBAgAGBQJNw7rDAAoJEDj4maMMRfCDfmUP/Rda/t0a1CHmDg8SrgcNjhlO G4u210HGsPd6C2SZTlclT/ba20D8QL99A9bSwEUolW61wZZk2on61ElFnWW3FcGQ tpeksYIZYJalEkAUMP5JKfbwEkKCA6jMNiYWD7QTHo38P82lX7mKlKRSw/E2WKW6 BJnmpPC3bo0DptAqXGWpF/0f1R3BMBnCtXfm6Y093O+rnufTTEeYaKNT6mZlTg5Z nYbCa8foMHoE1jMsLgEw6QXJYHhv9Fkrdez0J1IZNm/9JBlTxG8W9MTd8MA5hf6v XO9pqyxLHFERACulfsrlkXi/sobebuNDzjbh39CZRRQlfjhAvLbUlpTgQc+2Bm8o Nc93eTZFFr2Boe6lCo8e9yS1ApZ2x/JrqHv7zwqkaaLCgxkFQSQjvOaIUz6IqOJx UvJmad4Rdx9I2UmEpJQk9tOQWdHZwIIBI1Tn7iFXH8pNHDLFvt1rJ6x1wWl+Urwm +BQq66pYH77V8H2oTK40pAyJI1kA8w175UhMf5r6nIr9vgKIGPTGOiK7sNBPlIpA 2fXN+LkG+BD7+s3/nCXY62l6mZ/ZYNP/0lBMG6wzuKS+b4xFKlKk/qYC5JED0hZf BZ1wDREhgUCyQ96DYCog2r3vaOdMXO1kqthN5zZpa8FrptiKITk76HWS32TPUu4Y AdwIyuYZf7CLMLIPa+RD =yR78 -----END PGP SIGNATURE----- --=-=-=--