From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: bugfix attachment content-type as mime-type
	handling
In-Reply-To: <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>
References: <87li4om623.fsf@qmul.ac.uk>
	<1375200900-5650-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.15.2+225~g6062adf (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 31 Jul 2013 00:00:07 +0300
Message-ID: <m2txjbepbc.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, Jul 30 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Notmuch puts attachments in as declared content-type except when the
> content-type is application/octet-stream it tries to guess the type
> from the filename/extension. This means that viewing a pdf (for
> example) which is sent as application/octet-strem invokes the pdf
> viewer rather than just offering to save the part.
>
> Recent changes to the attachment handling (commit 1546387d) changed
> (broke) this. This patch stores the calculated mime-type with the part
> and changes the attachment part handlers can use it instead.
> ---
> This seems to fix the bug for me. I am not sure I like the naming
> (mime-type/content-type). Maybe it would be better to be explicit with
> something like calculated-content-type but probably that should be a
> more wholesale renaming.

I tested this (before and after applying the patch), using notmuch
remotely and viewing id:87ppu0t7yf.fsf@qmul.ac.uk .
Before applying emacs promted me an output file, after applying xdg-open
was executed - which executed evince to show the pdf document in that email.

If this restores the behaviour that was experienced with notmuch 0.15(.2)
then this imho is a good fix to be applied quickly before 0.16 is released...

>
> Best wishes
>
> Mark

Tomi