From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Bremner <david@tethera.net>, Austin Clements <amdragon@MIT.EDU>,
	notmuch@notmuchmail.org
Subject: Re: Parsing regression with gmime-2.6?
In-Reply-To: <87wr6xmlml.fsf@zancas.localnet>
References: <87d38w2e7h.fsf@zancas.localnet>
	<1331058417-13776-1-git-send-email-amdragon@mit.edu>
	<87wr6xmlml.fsf@zancas.localnet>
User-Agent: Notmuch/0.11.1+264~gb8fb66b (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 08 Mar 2012 10:27:21 -0800
Message-ID: <87fwdj6j92.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 06 Mar 2012 18:04:50 -0400, David Bremner <david@tethera.net> wrote:
> There seems to be something weird going on with gmime-2.6; maybe we
> didn't catch some api change?=20
>=20
> I noticed a surprising number of messages failing to parse, so I wrote a
> script to take a random sample of 1000 messages and run notmuch show on
> them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No
> failures are reported with gmime-2.4.

This *is* shockingly high, and very confusing.  Somehow all of the tests
pass?  That's very strange, particularly since there are enough real
messages used in the tests that we should experience at least one of
these failures, right?  Is there really nothing special about the
messages that are failing to parse?  Your later patches seem to indicate
that this has something to do with mbox, although you don't mention that
hear.

I thought I had been using gmime-2.6 for the last month, so I was very
skeptical of this issue.  Unfortunately I just found a bug in the
configure script [0] that meant I had actually been using gmime-2.4.
However, since fixing things and actually using gmime-2.6 now, I still
don't see any problems.

If the problem is specific to mbox, which we explicitly don't support, I
don't think this is tragic enough to warrant removing gmime-2.6 as a
dependency satisfier for 0.12 in Debian.  In an event, a more explicit
description of the problem you're seeing would be helpful.

jamie.

[0] id:"1331225101-24385-1-git-send-email-jrollins@finestructure.net"

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPWPoKAAoJEO00zqvie6q8pVgP/17SDeP2jDMIhsJjR5y46Zj5
69FWm0xq2olcXaQfDzLmEOcYZ6gfIvSDeySlZxLi6Q6NKrrNqVo/uphCVWgsHTeB
7UuuZcKP3BEyhk6lNAdQxp4t6ctU7Wu1JyZEOkzFgeoFqkBo8njYyAFO944/ooh0
oYM3vGsP4S2bH5u/XV6t03WDgkFWLX4phO2pR0GmDkbSDjYcy7t4h0ELA+4ayvbE
4RY8w/mugHl6qqbq6KlSUkdksokYVXGqSUc0T6IlWz4iaSMZNpF9TYiZ6z9bQod1
Z5cKzkCzAa79Q/Dt1DNy//DgSh1FJNZSMGYLctnK8stznaW+3Eyt5dZaffdwLBxq
95FLc/IJvtzWW3azeLHQ+/Tt0ee5Tr1WbpLsfGd/i5QQvvTgVk1qA4JFL3pqqEDz
lYKjQdozMu/N8U+nf7kX7XNDWz9mLP5eSqIQKXi1Y/6EVIMmp6JQQYyIB9QS0gG8
dN4nwWwWkP29DfdiTI1ZZlF59cqio2SF5RGLCF256WML144OqqrpwtlHC4mW0Hua
dBB19CCCBbFwuoAAokSTDGtRquz3ZGOWHIca811YUAyufzA7IRQvBoyc2f+T8zZl
ogIXsRYwnIFxT7/ETAwYDBTL0VxAHdGErEzSK9gr5v1yfAV3uyDhPN0UDBk0MTHc
q6+B43JtgnIrbSdRO0Xp
=WDWa
-----END PGP SIGNATURE-----
--=-=-=--