Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 81FF7431FAF for ; Mon, 23 Apr 2012 05:49:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OiSBkHGbmfhc for ; Mon, 23 Apr 2012 05:49:54 -0700 (PDT) Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D6073431FAE for ; Mon, 23 Apr 2012 05:49:53 -0700 (PDT) Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cryptobitch.de (Postfix) with ESMTPSA id 08CFA583DDE for ; Mon, 23 Apr 2012 14:49:52 +0200 (CEST) Received: by mail.jade-hamburg.de (Postfix, from userid 401) id 4173ADF2A3; Mon, 23 Apr 2012 14:49:51 +0200 (CEST) Received: from thinkbox.jade-hamburg.de (unknown [193.174.12.196]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: teythoon) by mail.jade-hamburg.de (Postfix) with ESMTPSA id 3F575DF2A0; Mon, 23 Apr 2012 14:49:50 +0200 (CEST) Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) (envelope-from ) id 1SMIiB-0002Qo-1q; Mon, 23 Apr 2012 14:49:47 +0200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Felipe Contreras , From: Justus Winter <4winter@informatik.uni-hamburg.de> In-Reply-To: References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de> <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de> <1335096477-27537-6-git-send-email-4winter@informatik.uni-hamburg.de> Message-ID: <20120423124946.31231.53523@thinkbox.jade-hamburg.de> User-Agent: alot/0.3+ Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close Date: Mon, 23 Apr 2012 14:49:46 +0200 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 12:49:54 -0000 Quoting Felipe Contreras (2012-04-23 14:36:33) > I don't think this is the right approach. If database_destroy truly > destroys the object, then we would want to do it only at garbage > collection, when it's not accessible any more. What if I want to > re-use the database from the Ruby code? > = > This would probably be better: > = >[...] You're probably right, I don't know the ruby bindings at all, I just wanted to preserve the old behavior. You are welcome to refine the ruby bindings later (or maintain them, I *believe* they are unmaintained, the last change was back in october 2011), but let's get this patch series in first. Cheers, Justus