Sender: Michal Nazarewicz <mpn@google.com>
From: Michal Nazarewicz <mina86@mina86.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] test: use perl instead of sed -r for portability
In-Reply-To:
 <66f7d91d6d2425149b5f4063274a6402662b9257.1354656085.git.jani@nikula.org>
Organization: http://mina86.com/
References: <cover.1354656085.git.jani@nikula.org>
	<66f7d91d6d2425149b5f4063274a6402662b9257.1354656085.git.jani@nikula.org>
User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Wed, 05 Dec 2012 00:01:07 +0100
Message-ID: <xa1tip8h2zik.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 04 2012, Jani Nikula wrote:
> Our OS X users report -r is not a supported option for sed. Use perl
> instead.
> ---
>  test/test-lib.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index f169785..31ed107 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -576,7 +576,7 @@ NOTMUCH_NEW ()
>=20=20
>  notmuch_search_sanitize ()
>  {
> -    sed -r -e 's/("?thread"?: ?)("?)................("?)/\1\2XXX\3/'
> +    perl -pe 's/("?thread"?: ?)("?)................("?)/\1\2XXX\3/'

Alternatively, this could just be convert into a basic regexp:

sed -e 's/\("\?thread"\?: \?"\?\)................\("\?\)/\1XXX\2/'

which I think is even more portable, no?

>  }
>=20=20
>  NOTMUCH_SHOW_FILENAME_SQUELCH=3D's,filename:.*/mail,filename:/XXX/mail,'

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJQvoCzAAoJECBgQBJQdR/0ZK8P/3+hH1xnbfy66eTYJQiIQquo
tnfeDsTk1PXj6AhmIWmeTs4h4fMKMrtPzC324KaVkf09bYeu0G7btMIGEMHK3IjX
l5O27/U1GmcW6a9s+T8deTin1jjml4SUoRSqC+kzUeCkOHUePoipYGD4ptH95vWe
/eGbnkYGufZbr20CU1hsht8IHvpAPR/i8dJV2Np6eAOS8+buQJ824+049YC3mt27
Euyr1a+ZSFPdV+ln9OASQ9uG6MCPC5K7sJl2u3BIyedMzOZM64Ul6vK10xkVrdwp
EdMBE9Rqkuo83rf5cPAIa0ZLR2BvdZpmatf0L89fg74jHCQ/C7PkxM3feVGtcyCJ
yHVVg8blbsBDv2GLxpdJ89DGbieM61dMH/8d96jlm+3BRbJKR9K0RcJ1p4kZDZ6Q
JIaEeyTM25sy5HHHz12U3BIcWptHP/Fo7K++HZ0QO+p1H74lilYrAmrxPYEIb0v5
zTeGHn46+Ywd1J4FEEipYQl9lEMUXoqbIMCnWXUg74cj1rQyfm/94u1y2pqrbef0
A4WzIBlIyR2X4htk0IOImxozxf12n4411rk9sOVaeU1Qz1KGVeAsXKKDmXeX02Fm
Btzfst/RyN6D6AKY+7JG0WUJxzCPZnHfwpBzTa8tv8TeBo9e+FC1GZGwP1DF9Qc4
E0JhvM7uVUSD9IVr5NRf
=EPBj
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--