Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B79FA4196F4 for ; Thu, 1 Jul 2010 21:42:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id le0JTDBM38L0 for ; Thu, 1 Jul 2010 21:41:56 -0700 (PDT) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by olra.theworths.org (Postfix) with ESMTP id D93134196F3 for ; Thu, 1 Jul 2010 21:41:55 -0700 (PDT) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OUY4V-0003pB-Jh for notmuch@notmuchmail.org; Fri, 02 Jul 2010 06:41:51 +0200 Received: from ip-118-90-137-151.xdsl.xnet.co.nz ([118.90.137.151]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 02 Jul 2010 06:41:51 +0200 Received: from olly by ip-118-90-137-151.xdsl.xnet.co.nz with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 02 Jul 2010 06:41:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: notmuch@notmuchmail.org From: Olly Betts Subject: Re: [PATCH 2/5] Add quotes around id:"message-id" queries. Date: Fri, 2 Jul 2010 04:41:43 +0000 (UTC) Lines: 16 Message-ID: References: <1278000507-22290-1-git-send-email-dmitry.kurochkin@gmail.com> <1278000507-22290-3-git-send-email-dmitry.kurochkin@gmail.com> X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ip-118-90-137-151.xdsl.xnet.co.nz User-Agent: slrn/pre1.0.0-11 (Linux) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2010 04:42:06 -0000 On 2010-07-01, Dmitry Kurochkin wrote: > - (concat "id:" (notmuch-show-get-prop :id props))) > + (concat "id:\"" (notmuch-show-get-prop :id props) "\"")) This is probably a good idea (the ".." example is arguably a Xapian bug so that should be fixed soon, but you find all sorts of junk in message-ids. However, the quoting feature this relies on was added in Xapian 1.0.18 (and 1.1.4), and with older versions this will break for *all* message-ids (even those which currently work). Also, if you're going to quote the message-id, you should escaping any " characters in the message-id (by doubling them). Cheers, Olly