Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 98D62431FBF for ; Sat, 4 Feb 2012 23:15:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kHgzipK3JJi5 for ; Sat, 4 Feb 2012 23:15:36 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 011D4431FAE for ; Sat, 4 Feb 2012 23:15:35 -0800 (PST) Received: by mail-bk0-f53.google.com with SMTP id 11so4650313bke.26 for ; Sat, 04 Feb 2012 23:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=DaB1/5PEp2BIOBxvSkfIlYUfcPItylAHYd1hIHI8yKU=; b=YF/l187rbLHF9bC7GpJaxFcfWciy7njwOjR+LSExFhRCAO2i1rYuGwP4B1OvQZ46TV axDa/wB9ETsdQEq1jqEuVrv8Mm13j8dngnlLskKXUokxTNtqmy+u8NkKmB+CpS8MaePn 6+BnrqnadMKZfdD6BjJgYtCwYpvnclffjY6sk= Received: by 10.204.151.218 with SMTP id d26mr6509832bkw.64.1328426135681; Sat, 04 Feb 2012 23:15:35 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id x20sm33004202bka.9.2012.02.04.23.15.34 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 04 Feb 2012 23:15:34 -0800 (PST) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH v5 09/12] emacs: relax tag syntax check in `notmuch-tag' function Date: Sun, 5 Feb 2012 11:13:50 +0400 Message-Id: <1328426033-21480-10-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.9 In-Reply-To: <1328426033-21480-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> <1328426033-21480-1-git-send-email-dmitry.kurochkin@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2012 07:15:36 -0000 The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not include whitespace characters. --- emacs/notmuch.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 862d9e8..b06d8a1 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -550,7 +550,7 @@ notmuch-after-tag-hook will be run." ;; Perform some validation (when (null tags) (error "No tags given")) (mapc (lambda (tag) - (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag) + (unless (string-match-p "^[-+]\\S-+$" tag) (error "Tag must be of the form `+this_tag' or `-that_tag'"))) tags) (run-hooks 'notmuch-before-tag-hook) -- 1.7.9