Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B708C431FBD for ; Wed, 22 Aug 2012 22:57:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bXgWzzN5v5Kc for ; Wed, 22 Aug 2012 22:57:30 -0700 (PDT) Received: from mx4.nic.fr (mx4.nic.fr [192.134.4.12]) by olra.theworths.org (Postfix) with ESMTP id 23E3C431FAE for ; Wed, 22 Aug 2012 22:57:29 -0700 (PDT) Received: from mx4.nic.fr (localhost [127.0.0.1]) by mx4.nic.fr (Postfix) with SMTP id C8029280539; Thu, 23 Aug 2012 07:57:27 +0200 (CEST) Received: from relay2.nic.fr (relay2.nic.fr [192.134.4.163]) by mx4.nic.fr (Postfix) with ESMTP id C31B128027D; Thu, 23 Aug 2012 07:57:27 +0200 (CEST) Received: from kaki.tech.prive.nic.fr (kaki.tech.prive.sqy.nic.fr [10.10.86.114]) by relay2.nic.fr (Postfix) with ESMTP id C0161B38004; Thu, 23 Aug 2012 07:56:57 +0200 (CEST) Received: by kaki.tech.prive.nic.fr (Postfix, from userid 1000) id 98D6752A143; Thu, 23 Aug 2012 05:56:57 +0000 (UTC) From: Kim Minh Kaplan To: Tomi Ollila Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com> <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com> <87y5l8z4dw.fsf@gmail.com> Date: Thu, 23 Aug 2012 05:56:57 +0000 In-Reply-To: (Tomi Ollila's message of "Wed, 22 Aug 2012 09:07:14 +0300") Message-ID: <87haruxiae.fsf@kaki.tech.prive.nic.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: notmuch X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2012 05:57:33 -0000 Tomi Ollila=C2=A0: > On Tue, Aug 21 2012, Ben Gamari wrote: > >> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the >> public API. > > Presuming that those variables are always numeric the comparison could be: > > if [ ${xapian_major_version} -gt 1 ] ||=20 > [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] ||= =20 > [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \ > ${xapian_subminor_version} -ge 6 ]; then > > (I could not figure out anything shorter and/or cleaner) Try: case "${xapian_version}" in 0.*|1.[01].*|1.2.[0-5]) ;; *) ... ;; esac Kim Minh.