Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F3D1B431FB6 for ; Sun, 27 Jul 2014 09:12:34 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCZAsS4ulhcj for ; Sun, 27 Jul 2014 09:12:28 -0700 (PDT) Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu [18.7.68.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7B1E3431FAE for ; Sun, 27 Jul 2014 09:12:28 -0700 (PDT) X-AuditID: 12074425-f79766d000006da8-6d-53d524ea4a6a Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) (using TLS with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id D4.5F.28072.AE425D35; Sun, 27 Jul 2014 12:12:26 -0400 (EDT) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id s6RGCPhp020720; Sun, 27 Jul 2014 12:12:26 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s6RGCNZI012245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 27 Jul 2014 12:12:24 -0400 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1XBR3e-0006wj-Lz; Sun, 27 Jul 2014 12:12:22 -0400 Date: Sun, 27 Jul 2014 12:12:22 -0400 From: Austin Clements To: Mark Walters Subject: Re: [PATCH 07/14] test: Tests for future version and unknown feature handling Message-ID: <20140727161222.GE13893@mit.edu> References: <1406433173-19169-1-git-send-email-amdragon@mit.edu> <1406433173-19169-8-git-send-email-amdragon@mit.edu> <871tt718xp.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871tt718xp.fsf@qmul.ac.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixG6novtK5WqwwfH1Nhar5/JYXL85k9mB yWPnrLvsHs9W3WIOYIrisklJzcksSy3St0vgyliy+wB7wX22ioVTP7A2MK5l7WLk5JAQMJGY ueslE4QtJnHh3nq2LkYuDiGB2UwSGyf9YYRwNjJKbJzcyAThnGaS2NV9AqpsCaPEzhNPGEH6 WQRUJf7tOsgOYrMJaEhs278cLC4ioCNx+9ACsDizgLTEt9/NYPuEBSIkvq9sBovzAtVMOr2O BWLoVEaJY5s7WCESghInZz5hgWjWkrjxD+RYDrBBy/9xgIQ5gXYtWzAXbJeogIrElJPb2CYw Cs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdC30cjNL9FJTSjcxggPbRXUH 44RDSocYBTgYlXh4BViuBAuxJpYVV+YeYpTkYFIS5bVVuhosxJeUn1KZkVicEV9UmpNafIhR goNZSYS38C1QOW9KYmVValE+TEqag0VJnPettVWwkEB6YklqdmpqQWoRTFaGg0NJgpcZGMFC gkWp6akVaZk5JQhpJg5OkOE8QMNfKgPV8BYXJOYWZ6ZD5E8x6nIs2v+ym0mIJS8/L1VKnHcJ SJEASFFGaR7cHFhCesUoDvSWMG8LSBUPMJnBTXoFtIQJaAmL/2WQJSWJCCmpBsZi7iXp/wQK lxqGz6h7yvyaJ/B17aab5lNs7smJrhIWLJURebNPQOFN2p9zXhWa/A3cQpzKWjwL7yqE31yY Y3QobqPSsqb2/d1v1bLnV0RbP4vXDTtfffNRlEjQ31W5Pq5fp+9cqfR8Q+Te7r7lpfmfPkwR X/Rr0raN6wKX8c+s+K1yunHvZTklluKMREMt5qLiRAAyOURtIwMAAA== Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2014 16:12:35 -0000 Quoth Mark Walters on Jul 27 at 9:51 am: > > On Sun, 27 Jul 2014, Austin Clements wrote: > > --- > > test/T530-upgrade.sh | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > Hi > > Just a quick comment on this patch so far. After this patch I got lots > of test failures in the second (old) part of T530-upgrade because I > hadn't downloaded the test databases: prior to this patch no tests > failed because those tests were skipped. > > Once I downloaded the databases everything was fine again so the problem > is just that this patch is breaking the automatic skipping of the > old tests in T530-upgrade. Oh. Apparently the prereq stuff only works before the first call to test_begin_subtest. Maybe I should just move the subtests I added to a separate top-level test?