From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME
	traversal.
In-Reply-To: <1323460468-4030-3-git-send-email-amdragon@mit.edu>
References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-3-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.10.2+74~g994a706 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 10 Dec 2011 13:19:21 -0800
Message-ID: <87liqk5dly.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Fri,  9 Dec 2011 14:54:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> +    /* Handle PGP/MIME parts */
> +    if (GMIME_IS_MULTIPART_ENCRYPTED (part) && out->ctx->decrypt) {
> +	if (out->children != 2) {
> +	    /* this violates RFC 3156 section 4, so we won't bother with it. */
> +	    fprintf (stderr, "Error: %d part(s) for a multipart/encrypted "
> +		     "message (should be exactly 2)\n",
> +		     out->children);
> +	} else {
> +	    out->is_encrypted = TRUE;

As per Dmitry's previous point, maybe it's better to do something like:

if (GMIME_IS_MULTIPART_ENCRYPTED (part)) {
    out->is_encrypted = TRUE;
    if (out->ctx->decrypt) {
        if (out->children != 2) {
...

And similarly for is_signed.

> +	    GMimeMultipartEncrypted *encrypteddata =
> +		GMIME_MULTIPART_ENCRYPTED (part);
> +	    out->decrypted_child = g_mime_multipart_encrypted_decrypt
> +		(encrypteddata, out->ctx->cryptoctx, &err);
> +	    if (out->decrypted_child) {
> +		out->decrypt_success = TRUE;
> +		out->is_signed = TRUE;
> +		out->sig_validity = g_mime_multipart_encrypted_get_signature_validity (encrypteddata);

Encrypted messages are not necessarily signed, so we need to be careful
about setting is_signed = TRUE based just on decryption status.  The
problem is that gmime's handling of this stuff (at least last I looked
in 2.4) is not so good.
g_mime_multipart_encrypted_get_signature_validity () should return
GMIME_SIGNATURE_STATUS_UNKNOWN if there's no signature, so I think
is_signed should be set TRUE only if sig_validity is not UNKNOWN.

I've really been meaning to overhaul this stuff for gmime 2.6.
Hopefully I'll start looking at that after these patches go through.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO48zZAAoJEO00zqvie6q83/oP/Ag9WhT8EENXOZwkZKzciUyT
GK32zjjTpFsH6hUUpCdaLSsvM9GfIpAuepLIb18ldPc8JSH+NoHu9ZFn2r99GD5I
ERnXvYBFmMGvt6p5AIg93h4CoHZpGOyhEzYblc/0aj6mwf6LwP9wQ+WE1AY2jc4F
A+sFdrIG1CmHD2TMkAc2qs/B2q0xi/Y7J8rbGHvnjl82MQbxsX8UWZoTg0ZQdOC4
7PkuuiVaXVHPn3MO5764Wq6zR0eWm4I23sarISamc3DXJ2FtLwdg7rKCNyq5Gfya
cEC5KaVZYs8MGKEDj0848LMlQTWmbZ83YLMCiyqeP7kzRZdvak1e/igNxe1n2mRZ
U19psMcHWSTDih8nXIw4fST22SLenqnaxgYldUbMpwxYmDwAwEcNUgXzgYZgR7QE
msBtGSBFw4Li1cMWr+/KDfYMB+U+PfXFBNBQzU1JG35JufJaE/jMiz1FZHhruZz0
T8SXXEfcL058c8GI1Ux06IkFrNoCDrXxaLumyN2pM5Q1iRHBlkVrCwqDHbbdCLM6
CuaNsdf1lXTC0gX06iH0YuonYEWvUjwDheq2Lai2+BeuB4MP+AGfc+594cYzLmOm
OmUY07kqJztDruUs0AGrUCbWvIsPV+Gl6JLlq6ikGkCLgDxqnOLOPbxN4eIShKt/
4IRvUASm89TrtmmiCflt
=JrFN
-----END PGP SIGNATURE-----
--=-=-=--