From: Carl Worth <cworth@cworth.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH v2] notmuch.el: Make notmuch-show buffer name
	first subject, instead of thread-id
In-Reply-To: <m1wryiayhg.fsf@watt.gilman.jhu.edu>
References: <m1y6iybc5h.fsf@watt.gilman.jhu.edu>
	<m1wryiayhg.fsf@watt.gilman.jhu.edu>
Date: Wed, 07 Apr 2010 10:46:01 -0700
Message-ID: <87zl1f5f6u.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 12 Feb 2010 17:19:23 -0500, Jesse Rosenthal <jrosenthal@jhu.edu> wr=
ote:
> Change the buffer name to a uniquified subject of the thread (i.e. the
> subject of the first message in the thread) instead of the thread-id. This
> is more meaningful to the user, and will make it easier to scroll through
> numerous open buffers.

A very lovely change, Jesse! Thanks for this (which is now pushed). And
again, thanks to Sebastian for guiding the patch through the file
renaming.

There is one minor issue with this patch which is that viewing an
identical thread more than once will bring up a new buffer rather than
re-using the existing buffer. But of course, we *want* a separate buffer
if the thread-ID is different but the (abbreviated) subject just happens
to match. So there would have to be something clever to do the right
thing here. I'm not making this minor regression block the patch, since
it's so nice otherwise.

> This version of the patch improves on the first version by ensuring that
> the buffer names are unique, and that the `notmuch-show' command can
> still be used interactively.
>=20
> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
> ---
>  notmuch.el |   25 +++++++++++++++++++------
>  1 files changed, 19 insertions(+), 6 deletions(-)

That last paragraph above is good guidance for understanding the patch,
but not useful as part of the permanent commit history. So I removed it
before pushing the commit. In the future, you can put text like that
*after* the "---" just below your Signed-off-by and then "git am" will
automatically ignore it.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLvMTZ6JDdNq8qSWgRAgZ9AJsGgeH+ChDgbxFimhtgfjfys/iD0wCfT8LG
H7D+rZqKBF+TgaWDrmQF+zM=
=ktKL
-----END PGP SIGNATURE-----
--=-=-=--