Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B36E1429E54 for ; Mon, 23 Jan 2012 17:51:00 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gr+qhg5Y68Bz for ; Mon, 23 Jan 2012 17:50:59 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4DA2F429E21 for ; Mon, 23 Jan 2012 17:50:59 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so1896327bkb.26 for ; Mon, 23 Jan 2012 17:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=5jWYBeucQbpa1RlAUVSLOpewmKI3iKEDiVT2MHb0onc=; b=b7SAjdHeh0bZwnBTLEFaSl86EhZ0bArnRkzoO4wRCHCpWLB4m0F6XvT5TWTSPcbLBP usjUjAHcK+xRvgtURHDU/eLdheIHExrSyUvdloEBqHq4kzoxjxifKxG9sshEyR61VV2O 8Oey3txhvCCwkBMOO6cCSiW9Kqj/yD7Jz7CWw= Received: by 10.204.153.15 with SMTP id i15mr4054374bkw.43.1327369857902; Mon, 23 Jan 2012 17:50:57 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ez5sm22032505bkc.15.2012.01.23.17.50.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 17:50:57 -0800 (PST) From: Dmitry Kurochkin To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [RFC PATCH 5/5] show: Simplify new text formatter code In-Reply-To: <1326332973-30225-6-git-send-email-amdragon@mit.edu> References: <1326332973-30225-1-git-send-email-amdragon@mit.edu> <1326332973-30225-6-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.11+100~gd650abf (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Jan 2012 05:49:52 +0400 Message-ID: <87lioxna2n.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 01:51:00 -0000 On Wed, 11 Jan 2012 20:49:33 -0500, Austin Clements wrote: > This makes the text formatter take advantage of the new code > structure. The previously duplicated header logic is now unified, > several things that we used to compute repeatedly across different > callbacks are now computed once, and the code is generally simplified. > > Unifying the header logic causes this to format some dates slightly > differently, so the two affected test cases are updated. Thanks for these patches, Austin. They are a definite improvement for notmuch show code. I hope it would soon get pushed to master. And I hope more patches would follow :) Few minor comments below. > --- > notmuch-show.c | 84 ++++++++++++---------------------------------------- > test/crypto | 2 +- > test/thread-naming | 16 +++++----- > 3 files changed, 28 insertions(+), 74 deletions(-) > > diff --git a/notmuch-show.c b/notmuch-show.c > index 3241965..1689222 100644 > --- a/notmuch-show.c > +++ b/notmuch-show.c > @@ -175,67 +175,42 @@ format_part_text (const void *ctx, mime_node_t *node, > GMimeObject *meta = node->envelope_part ? > GMIME_OBJECT (node->envelope_part) : node->part; > GMimeContentType *content_type = g_mime_object_get_content_type (meta); > + GMimeContentDisposition *disposition = > + g_mime_object_get_content_disposition (meta); > + notmuch_bool_t attachment = disposition && > + strcmp (disposition->disposition, GMIME_DISPOSITION_ATTACHMENT) == 0; If I did not miss anything, attachment is used only as following: attachment ? "attachment" : "part" Please make it const char[] and set to "attachment" or "part". > + notmuch_bool_t leaf = GMIME_IS_PART (node->part); Please add const where possible to local variables (e.g. attachment, leaf). > int i; > > if (node->envelope_file) { > notmuch_message_t *message = node->envelope_file; > - const char *headers[] = { > - "Subject", "From", "To", "Cc", "Bcc", "Date" > - }; > - const char *name, *value; > - unsigned int i; > > - printf ("\fmessage{ "); > - printf ("id:%s depth:%d match:%d filename:%s\n", > + printf ("\fmessage{ id:%s depth:%d match:%d filename:%s\n", > notmuch_message_get_message_id (message), > indent, > notmuch_message_get_flag (message, NOTMUCH_MESSAGE_FLAG_MATCH), > notmuch_message_get_filename (message)); > - > - printf ("\fheader{\n"); > - > - printf ("%s\n", _get_one_line_summary (ctx, message)); > - > - for (i = 0; i < ARRAY_SIZE (headers); i++) { > - name = headers[i]; > - value = notmuch_message_get_header (message, name); > - if (value && strlen (value)) > - printf ("%s: %s\n", name, value); > - } > - printf ("\fheader}\n"); Yay! Only one header-printing code left :) > } else { > - GMimeContentDisposition *disposition = g_mime_object_get_content_disposition (meta); > const char *cid = g_mime_object_get_content_id (meta); > + const char *filename = leaf ? > + g_mime_part_get_filename (GMIME_PART (node->part)) : NULL; > > - if (disposition && > - strcmp (disposition->disposition, GMIME_DISPOSITION_ATTACHMENT) == 0) > - { > - printf ("\fattachment{ ID: %d", node->part_num); > - > - } else { > - > - printf ("\fpart{ ID: %d", node->part_num); > - } > - > - if (GMIME_IS_PART (node->part)) > - { > - const char *filename = g_mime_part_get_filename (GMIME_PART (node->part)); > - if (filename) > - printf (", Filename: %s", filename); > - } > - > + printf ("\f%s{ ID: %d", attachment ? "attachment" : "part", node->part_num); > + if (filename) I always forget about it, can we declare variables inside if condition like in C++? I.e.: if (const char *filename = leaf ? g_mime_part_get_filename (GMIME_PART (node->part)) : NULL) If yes, I would prefer to use this style where possible. > + printf (", Filename: %s", filename); > if (cid) > printf (", Content-id: %s", cid); > - I would revert blank line changes. But I do not insist :) > printf (", Content-type: %s\n", g_mime_content_type_to_string (content_type)); > } > > - if (node->envelope_part) { > + if (GMIME_IS_MESSAGE (node->part)) { This condition is repeated at least twice. Please consider moving the message variable below to the top level and using it in the conditions. Regards, Dmitry > GMimeMessage *message = GMIME_MESSAGE (node->part); > InternetAddressList *recipients; > const char *recipients_string; > > printf ("\fheader{\n"); > + if (node->envelope_file) > + printf ("%s\n", _get_one_line_summary (ctx, node->envelope_file)); > printf ("Subject: %s\n", g_mime_message_get_subject (message)); > printf ("From: %s\n", g_mime_message_get_sender (message)); > recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_TO); > @@ -248,9 +223,11 @@ format_part_text (const void *ctx, mime_node_t *node, > printf ("Cc: %s\n", recipients_string); > printf ("Date: %s\n", g_mime_message_get_date_as_string (message)); > printf ("\fheader}\n"); > + > + printf ("\fbody{\n"); > } > > - if (!node->envelope_file) { > + if (leaf) { > if (g_mime_content_type_is_type (content_type, "text", "*") && > !g_mime_content_type_is_type (content_type, "text", "html")) > { > @@ -258,24 +235,12 @@ format_part_text (const void *ctx, mime_node_t *node, > g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE); > show_text_part_content (node->part, stream_stdout); > g_object_unref(stream_stdout); > - } > - else if (g_mime_content_type_is_type (content_type, "multipart", "*") || > - g_mime_content_type_is_type (content_type, "message", "rfc822")) > - { > - /* Do nothing for multipart since its content will be printed > - * when recursing. */ > - } > - else > - { > + } else { > printf ("Non-text part: %s\n", > g_mime_content_type_to_string (content_type)); > } > } > > - if (GMIME_IS_MESSAGE (node->part)) { > - printf ("\fbody{\n"); > - } > - > for (i = 0; i < node->nchildren; i++) > format_part_text (ctx, mime_node_child (node, i), indent, params); > > @@ -286,18 +251,7 @@ format_part_text (const void *ctx, mime_node_t *node, > if (node->envelope_file) { > printf ("\fmessage}\n"); > } else { > - GMimeContentDisposition *disposition; > - > - disposition = g_mime_object_get_content_disposition (meta); > - if (disposition && > - strcmp (disposition->disposition, GMIME_DISPOSITION_ATTACHMENT) == 0) > - { > - printf ("\fattachment}\n"); > - } > - else > - { > - printf ("\fpart}\n"); > - } > + printf ("\f%s}\n", attachment ? "attachment" : "part"); > } > } > > diff --git a/test/crypto b/test/crypto > index 0af4aa8..6723ef8 100755 > --- a/test/crypto > +++ b/test/crypto > @@ -157,7 +157,7 @@ Notmuch Test Suite (2000-01-01) (encrypted inbox) > Subject: test encrypted message 001 > From: Notmuch Test Suite > To: test_suite@notmuchmail.org > -Date: 01 Jan 2000 12:00:00 -0000 > +Date: Sat, 01 Jan 2000 12:00:00 +0000 > header} > body{ > part{ ID: 1, Content-type: multipart/encrypted > diff --git a/test/thread-naming b/test/thread-naming > index 41b97d9..b7c96f2 100755 > --- a/test/thread-naming > +++ b/test/thread-naming > @@ -71,7 +71,7 @@ Notmuch Test Suite (2001-01-05) (unread) > Subject: thread-naming: Initial thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Fri, 05 Jan 2001 15:43:56 -0000 > +Date: Fri, 05 Jan 2001 15:43:56 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -85,7 +85,7 @@ Notmuch Test Suite (2001-01-06) (inbox unread) > Subject: thread-naming: Older changed subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Sat, 06 Jan 2001 15:43:56 -0000 > +Date: Sat, 06 Jan 2001 15:43:56 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -99,7 +99,7 @@ Notmuch Test Suite (2001-01-07) (inbox unread) > Subject: thread-naming: Newer changed subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Sun, 07 Jan 2001 15:43:56 -0000 > +Date: Sun, 07 Jan 2001 15:43:56 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -113,7 +113,7 @@ Notmuch Test Suite (2001-01-08) (unread) > Subject: thread-naming: Final thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Mon, 08 Jan 2001 15:43:56 -0000 > +Date: Mon, 08 Jan 2001 15:43:56 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -127,7 +127,7 @@ Notmuch Test Suite (2001-01-09) (inbox unread) > Subject: Re: thread-naming: Initial thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Tue, 09 Jan 2001 15:43:45 -0000 > +Date: Tue, 09 Jan 2001 15:43:45 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -141,7 +141,7 @@ Notmuch Test Suite (2001-01-10) (inbox unread) > Subject: Aw: thread-naming: Initial thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Wed, 10 Jan 2001 15:43:45 -0000 > +Date: Wed, 10 Jan 2001 15:43:45 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -155,7 +155,7 @@ Notmuch Test Suite (2001-01-11) (inbox unread) > Subject: Vs: thread-naming: Initial thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Thu, 11 Jan 2001 15:43:45 -0000 > +Date: Thu, 11 Jan 2001 15:43:45 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > @@ -169,7 +169,7 @@ Notmuch Test Suite (2001-01-12) (inbox unread) > Subject: Sv: thread-naming: Initial thread subject > From: Notmuch Test Suite > To: Notmuch Test Suite > -Date: Fri, 12 Jan 2001 15:43:45 -0000 > +Date: Fri, 12 Jan 2001 15:43:45 +0000 > header} > body{ > part{ ID: 1, Content-type: text/plain > -- > 1.7.7.3 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch