Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 150BC429E59 for ; Sat, 1 Jun 2013 12:48:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UZiVTC0QxCoi for ; Sat, 1 Jun 2013 12:48:23 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7DB2F431FDE for ; Sat, 1 Jun 2013 12:48:23 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r51JmJ8V020719; Sat, 1 Jun 2013 16:48:19 -0300 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Uirml-00077Q-GK; Sat, 01 Jun 2013 16:48:19 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1Uirmf-0001Xr-QG; Sat, 01 Jun 2013 16:48:13 -0300 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) implemented In-Reply-To: <1354970914-18342-3-git-send-email-markwalters1009@gmail.com> References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com> <1354970914-18342-3-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.15.2+114~g3b2344e (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 01 Jun 2013 16:48:13 -0300 Message-ID: <87zjv91uki.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jun 2013 19:48:31 -0000 Mark Walters writes: > Previously pick had no actions based on the entire thread: this adds > some. Note in this version '*' is bound to `tag thread' which is not > consistent with search or show. However it still might be the most > natural thing (as it is similar to running * in the show pane). Hmm. not sure about this. But since nobody complained in six months, let's go with it unless they wake up. > + (setq tag-changes (funcall 'notmuch-tag > (notmuch-pick-get-messages-ids-thread-search) tag-changes)) Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here? Personally I'd use let instead of setq here, but ymmv. > +Archive each message currently shown by applying the tag changes > +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by > +default). If a prefix argument is given, the messages will be > +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' > +will be reversed. It seems to me the default value for notmuch-archive-tags should not be hard-coded into this docstring, especially since notmuch-archive-tags turns into a link in the help text. d