MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <1334999750-21811-2-git-send-email-markwalters1009@gmail.com>
References: <1334999750-21811-1-git-send-email-markwalters1009@gmail.com>
	<1334999750-21811-2-git-send-email-markwalters1009@gmail.com>
Date: Sat, 21 Apr 2012 12:10:14 -0600
Message-ID:
 <CAMoJFUvOU1OzqPn7eCNMfECuFm+09B+YSkivTX79VTQJ6_wSjg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] cli: make --entire-thread=false work for
	format=json.
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Mark Walters <markwalters1009@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: notmuch@notmuchmail.org
Precedence: list

On Sat, Apr 21, 2012 at 03:15, Mark Walters <markwalters1009@gmail.com> wrote:
> The --entire-thread option in notmuch-show.c defaults to true when
> format=json. Previously there was no way to turn this off. This patch
> makes it respect --entire-thread=false.
>
> The one subtlety is that we initialise a notmuch_bool_t to -1 to
> indicate that the option parsing has not set it. This allows the code
> to distinguish between the option being omitted from the command line,
> and the option being set to false on the command line.
>
> Finally, all formats except Json can output empty messages for non
> entire-thread, but in Json format we need to output {} to keep the
> other elements (e.g. the replies to this message) in the correct
> place.

LGTM. You can probably remove the relevant item from devel/TODO as well!

-- Adam