Date: Tue, 03 Feb 2015 00:52:41 +0100
From: Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
To: Franz Fellner <alpine.art.de@gmail.com>, 
	Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>
Message-ID:
 <54d00dc9af6cb_47c3ff0b58781fcde@bartels-MacBook-Pro.local.notmuch>
In-Reply-To: <54bff2427d3c1_5b9d145d304d6@TP_L520.notmuch>
References: <1412181367-10906-1-git-send-email-imain@stemwinder.org>
	<54bd89e062df1_a663fec9d49e200a3@bts-MacBook-Pro.local.notmuch>
	<54bff2427d3c1_5b9d145d304d6@TP_L520.notmuch>
Subject: RE: [PATCH] VIM: Automatically refresh folder screen
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: notmuch@notmuchmail.org
Precedence: list

Franz Fellner wrote:
> Hi Bartosz,
> 
> Great to see one more person interested in notmuch-vim! Hopefully this will make review a little bit easier.
> 
> Bartosz Telenczuk wrote:
> > Ian Main wrote:
> > > This patch makes the folder screen refresh each time you 'enter' it.
> > > This way when you read a folder and mark items as read the changes are
> > > reflected immediately when you return to the folder view.
> > 
> > That is a good starting point, but why don't we refresh every time we mark an item in the folder screen?
> 
> Personally I don't see the benefit. It's a useless call to notmuch for every cursor-move. Especially with the current inefficient implementation.

I meant that we should refresh after one tags a thread (for example archive it with "A" key). It is slightly annoying that the messages do not disappear after being archived. In my version of the plugin it also causes a wrong thread to be opened when I enter it.

Anyway, this is a small incremental change that can be implemented later.. It should not hold back the patch. These patches are already great and should accepted as soon as possible, so we can move forward and synchronize notmuch-repo with Ian's repo and possibly catch up with emacs (sic!) client.

Cheers,

Bartosz