Return-Path: <schnouki@schnouki.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5BAF8429E26
	for <notmuch@notmuchmail.org>; Thu, 15 Dec 2011 11:42:40 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 1.675
X-Spam-Level: *
X-Spam-Status: No, score=1.675 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	URIBL_BLACK=1.775] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Vi7BljsbnE-w for <notmuch@notmuchmail.org>;
	Thu, 15 Dec 2011 11:42:39 -0800 (PST)
Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])
	by olra.theworths.org (Postfix) with ESMTP id BC8A8431FD0
	for <notmuch@notmuchmail.org>; Thu, 15 Dec 2011 11:42:39 -0800 (PST)
Received: from odin.local (nancy.schnouki.net [78.238.0.45])
	by ks3536.kimsufi.com (Postfix) with ESMTPSA id 6F6AC6A0026;
	Thu, 15 Dec 2011 20:42:37 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;
	s=key-schnouki; t=1323978157;
	bh=2mM3xhUSPMviFZ2Vtg5c1L4zsT7K9ItXmH9t2mZa8/8=;
	h=From:To:Subject:Date:Message-Id;
	b=cdsUXyGj9NMsqsM+B/dKpycdkE/68z5Q9Cd8e00fuKDEjWQMgcRmW8cM3kl7/ir/6
	QGik2vzpeFFEN7vhvPfJbWDN/fvISxD2uSb5kazbGMacAZl5Xjeb7y0xLG4PMP9N9c
	CPh4EQS42FvUC5GLPXQLBgCgMZ7MySxoh9Mv4N7c=
From: Thomas Jost <schnouki@schnouki.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] Fix build with binutils-2.22
Date: Thu, 15 Dec 2011 20:41:58 +0100
Message-Id: <1323978118-23954-1-git-send-email-schnouki@schnouki.net>
X-Mailer: git-send-email 1.7.8
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2011 19:42:40 -0000

binutils-2.22 changes the behaviour of ld by defaulting to
--no-copy-dt-needed-entries, which means that required objects/libs are not
"indirectly" linked through intermediate objects/libs anymore. As a consequence,
when using binutils-2.22, building symbol-test fails with the following error:

    /usr/bin/ld: test/symbol-test.o: undefined reference to symbol
    'std::basic_string<char, std::char_traits<char>, std::allocator<char>
    >::~basic_string()@@GLIBCXX_3.4'

    /usr/bin/ld: note: 'std::basic_string<char, std::char_traits<char>,
    std::allocator<char> >::~basic_string()@@GLIBCXX_3.4' is defined in DSO
    /usr/lib/libstdc++.so.6 so try adding it to the linker command line

    /usr/lib/libstdc++.so.6: could not read symbols: Invalid operation

An easy fix is to link using CXX instead of CC.
---
Hi there,

This build issue happens on Arch Linux. For more details, the relevant binutils
changelog is here: http://ur1.ca/6px8j, and more explanations are available on
the Fedora wiki: https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
(People who read the arch-general ML may want to read the thread starting at
id:"1323458274-sup-9064@eris".)

Best regards,
Thomas

 test/Makefile.local |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/test/Makefile.local b/test/Makefile.local
index 6cb6c82..fa2df73 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -17,7 +17,7 @@ $(dir)/smtp-dummy: $(smtp_dummy_modules)
 	$(call quiet,CC) $^ -o $@
 
 $(dir)/symbol-test: $(dir)/symbol-test.o
-	$(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
+	$(call quiet,CXX) $^ -o $@ -Llib -lnotmuch -lxapian
 
 .PHONY: test check
 
-- 
1.7.8