Date: Tue, 17 Jan 2012 15:32:11 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: David Edmondson <dme@dme.org>
Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions
Message-ID: <20120117203211.GQ16740@mit.edu>
References: <1326258173-21163-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-4-git-send-email-amdragon@mit.edu>
	<87wr8tsvit.fsf@servo.finestructure.net>
	<cunfwfg57uh.fsf@hotblack-desiato.hh.sledj.net>
	<20120116192836.GC16740@mit.edu>
	<CA+eQo_3xxuhgUUXWXWyVD1LFhvhkw2psbA3ZnFnZk=BjjHXy8w@mail.gmail.com>
	<cunpqeir912.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cunpqeir912.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org, Jeremy Nickurak <jeremy@nickurak.ca>
Precedence: list

Quoth David Edmondson on Jan 17 at  9:08 am:
> On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak <jeremy@nickurak.ca> wrote:
> > On Mon, Jan 16, 2012 at 12:28, Austin Clements <amdragon@mit.edu> wrote:
> > >> Having "deleted" and "spam" as default settings in the configuration
> > >> file might be more reasonable.
> > 
> > If I read correctly:
> > 
> > 1) If no exclude options are in the config file, none should be used.
> 
> Yes.
> 
> > 2) On notmuch setup, "deleted" and "spam" should be added to .notmuch-config
> 
> I might argue between 'should' and 'could', but the sense is correct.

Oh, I think I see.  I don't know if I can do precisely that, since the
config code doesn't know if it's being called from setup, but is
something like this essentially what you're suggesting?

    if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) {
        if (is_new) {
            const char *tags[] = { "deleted", "spam" };
            notmuch_config_set_auto_exclude_tags (config, tags, 2);
        } else {
            notmuch_config_set_auto_exclude_tags (config, NULL, 0);
        }
    }

(where is_new is TRUE if this is a brand-new config file)