From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/9] emacs: Unify common key bindings and lots more
In-Reply-To: <1377793557-28878-1-git-send-email-amdragon@mit.edu>
References: <1377793557-28878-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 01 Sep 2013 08:50:08 +0100
Message-ID: <87k3j12d73.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


This patch series LGTM +1 modulo your fix for Jani's problem with point
placement (which as we commented on irc is only a problem with emacs
24).

Patch 2 doing the point placement is the only one I have any concerns
about: but based on our discussion on irc I agree that point placement
when killing and reloading buffers (as opposed to modifying the existing
buffer) is inherently very fragile and this makes it no worse.

Finally, two other comments: first, I like the ability to turn off the
auto-refresh (since I often use notmuch over an erratic ssh link).

Secondly, I was initially unsure about the amount of churn to get a
global keymap but with other things being moved or added to it this does
look worthwhile. In particular, your draft notmuch-go (keyboard
shortcuts for search) looks really nice.

Best wishes

Mark



On Thu, 29 Aug 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> This series moves several common key bindings into a shared
> notmuch-wide keymap.  To get there, it first cleans up several things
> so that all notmuch modes have common commands to put into a common
> keymap.
>
> In the process, this fixes inconsistent sort ordering reported in
> id:m2bo5c5h8l.fsf@ramakrmu-mac.i-did-not-set--mail-host-address--so-tickle-me,
> improves the currently fragile hello refresh behavior, combines
> several mostly-duplicated commands, and improves the notmuch-help
> implementation.
>
> This passes all of the tests and basic interactive testing, but it
> would be good for people to exercise it.
>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch