Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2115449168F for ; Tue, 9 Mar 2010 11:42:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.384 X-Spam-Level: X-Spam-Status: No, score=-2.384 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.156, BAYES_20=-0.74] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sKuQI10QiWyy; Tue, 9 Mar 2010 11:42:49 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 68DEA491688; Tue, 9 Mar 2010 11:42:49 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 0C5D054C006; Tue, 9 Mar 2010 10:25:59 -0800 (PST) From: Carl Worth To: "Aneesh Kumar K. V" In-Reply-To: <87ws0ujcv0.fsf@linux.vnet.ibm.com> References: <1259830005-3439-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <87638mfth1.fsf@yoom.home.cworth.org> <87ws0ujcv0.fsf@linux.vnet.ibm.com> Date: Tue, 09 Mar 2010 10:25:58 -0800 Message-ID: <87zl2hic7d.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: "Aneesh Kumar K.V" , notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH 1/2] notmuch-reply: Add support for replying only to sender X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 19:42:50 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 11 Dec 2009 11:01:15 +0530, "Aneesh Kumar K. V" wrote: > On Fri, 04 Dec 2009 11:07:54 -0800, Carl Worth wrote: > > On Thu, 3 Dec 2009 14:16:44 +0530, "Aneesh Kumar K.V" wrote: > > >=20 > > > This patch add --format=3Dsender-only option. > >=20 > > I like the idea here, (and agree that an 'R' keybinding would be great). > >=20 > > But surely there's a way to implement this with dramatically less code > > duplication? >=20 > I sent an updated patch which did the above with less code duplication. A= ny > chance of getting this merged ? Thanks for the updated patch, (and I sincerely apologize for my late response). I still like the functionality and keybinding, and it's great to see less code duplication in this patch, but I also agree with the point Jed made: I think --format=3D should not be used for this, formatting is orthogonal to selecting recipients. We're already using --format for selection JSON output, for example. And it's not totally unreasonable to expect that someone might want JSON output from "notmuch reply" as well. So let's use a separate option here. Perhaps: --recipient=3Dall|sender or so? =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLlpK26JDdNq8qSWgRApTIAJ4wtPftEp0ypBU6eJXXQFKs6d8NwwCePwUF 0HGTM4iVPoWjNz8QDp9Xglk= =LgoU -----END PGP SIGNATURE----- --=-=-=--