Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8E9E1429E21 for ; Mon, 3 Oct 2011 14:00:47 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YxcfyfxXSHCp for ; Mon, 3 Oct 2011 14:00:47 -0700 (PDT) Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU [18.7.68.36]) by olra.theworths.org (Postfix) with ESMTP id DFA4C431FB6 for ; Mon, 3 Oct 2011 14:00:46 -0700 (PDT) X-AuditID: 12074424-b7ef76d0000008dc-cd-4e8a227e6590 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id D9.64.02268.E722A8E4; Mon, 3 Oct 2011 17:00:46 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id p93L0jAd010064; Mon, 3 Oct 2011 17:00:45 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id p93L0eW5018049 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Mon, 3 Oct 2011 17:00:40 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.72) (envelope-from ) id 1RApfB-0003bx-Sn; Mon, 03 Oct 2011 17:03:01 -0400 Date: Mon, 3 Oct 2011 17:03:01 -0400 From: Austin Clements To: Ali Polatel Subject: Re: [PATCH v2 0/2] Better error handling Message-ID: <20111003210301.GE17905@mit.edu> References: <20111003203837.GA22365@hayalet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hRV1q1T6vIzWDZFzGLVt7uMFtdvzmS2 6NvzjdWB2WPj0yZ2j52z7rJ7PFt1izmAOYrLJiU1J7MstUjfLoErY9Gh9UwFv1gq5t9rY2xg fM/cxcjJISFgInHrSBMLhC0mceHeerYuRi4OIYF9jBIzf21jhHDWM0o86HjFBOGcYJLYtf4q K4SzhFGi5e9SsFksAioSPXsbWUFsNgENiW37lwO1c3CICChL9G1PBDGZBaIl5nToglQICxhK PH01gQnE5hXQkbjw+TrYFCGBMIl/Z+4xQsQFJU7OfAJ2HbOAlsSNfy+ZIMZISyz/xwES5gR6 4N2aDWAlokAHXNvfzjaBUWgWku5ZSLpnIXQvYGRexSibklulm5uYmVOcmqxbnJyYl5dapGuu l5tZopeaUrqJERTo7C4qOxibDykdYhTgYFTi4S383OknxJpYVlyZe4hRkoNJSZT3rmKXnxBf Un5KZUZicUZ8UWlOavEhRgkOZiUR3u23gcp5UxIrq1KL8mFS0hwsSuK8Njsd/IQE0hNLUrNT UwtSi2CyMhwcShK8b0CGChalpqdWpGXmlCCkmTg4QYbzAA0HW8xbXJCYW5yZDpE/xagoJc77 FiQhAJLIKM2D64UloleM4kCvCPM+BKniASYxuO5XQIOZgAan3gW5urgkESEl1cCoKRK8qSjn x2nLlT9NG6IZZYrLMo+veSmRcDOqTsen2/1eaqrxldLfnSwKQb//9Jw9PetJcdZHPa7q3B6H nZmeFw+vPa5YJrDBt2+W5pL3TOrHTZZEby6utTrzZwXvW9HiL32TL4XwLf91fv7Ptx/ZMqSm Vk9qm6u7/fCnbSK9Oz2LZcV/rjmqxFKckWioxVxUnAgANgYLtx8DAAA= Cc: Ali Polatel , Notmuch Mailing List X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2011 21:00:47 -0000 LGTM. Quoth Ali Polatel on Oct 03 at 11:40 pm: > From: Ali Polatel > > New set of patches addressing the issues in the mail > "id:20111003174308.GD17905@mit.edu" > > Ali Polatel (2): > lib: destroy message object after message removal > lib: make find_message{,by_filename) report errors > > lib/database.cc | 95 +++++++++++++++++++++++++++++++++++----------------- > lib/message.cc | 8 +++-- > lib/notmuch.h | 60 +++++++++++++++++++++++---------- > notmuch-new.c | 4 ++- > notmuch-restore.c | 11 ++++-- > 5 files changed, 120 insertions(+), 58 deletions(-)