Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 66C904196F0 for ; Mon, 26 Apr 2010 10:42:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XX2T5RkNhLXE; Mon, 26 Apr 2010 10:41:59 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8BCFE431FC1; Mon, 26 Apr 2010 10:41:59 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 29065568DEC; Mon, 26 Apr 2010 10:41:59 -0700 (PDT) From: Carl Worth To: David Edmondson , Dirk Hohndel , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface In-Reply-To: <87eii2ch2r.fsf@ut.hh.sledj.net> References: <1272294424-17363-1-git-send-email-dme@dme.org> <87eii2ch2r.fsf@ut.hh.sledj.net> User-Agent: Notmuch/0.2-202-g01ec4d3 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Mon, 26 Apr 2010 10:41:59 -0700 Message-ID: <877hnudsbc.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 17:42:00 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 26 Apr 2010 17:30:04 +0100, David Edmondson wrote: > On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel = wrote: > > This is lacking a committ message... Thanks for the review, Dirk! Much appreciated. > I wasn't sure what else to say. Here's what I came up with in my --amend of the commit message: emacs: `notmuch' should display the `notmuch-hello' interface =20=20=20=20 Reviewed-by: Carl Worth =20=20=20=20 The notmuch-hello functionality is now sufficiently useful that we want to make it the default view of notmuch for new users. This also effectively hides the "hello" name from the user, so we'll be free to change that in the implementation if necessary. =20=20=20=20 This change also shuffles the requires between notmuch.el and notmuch-hello.el. This fixes things so that our documented (require 'notmuch) is sufficient for getting the notmuch-hello functionality. =20=20=20=20 Finally, the shuffling caused the notmuch-search-oldest-first variable from one file to the other. While doing that, give this variable the defcustom treatment for easier customization. Pushed. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFL1dBn6JDdNq8qSWgRAuMTAJ4oyGf8Xa47HtH+1by/mSDoPE/jMACeIWQ0 gST+YtoAJXcNd0JAdbJayRk= =TYP4 -----END PGP SIGNATURE----- --=-=-=--