From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups
In-Reply-To: <1342140319-19859-1-git-send-email-amdragon@mit.edu>
References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.13.2+63~g1397edd (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 13 Jul 2012 19:12:37 +0100
Message-ID: <871ukf8r8q.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 13 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> This series builds on the JSON-based search series [0] to clean up
> several other aspects of search-mode.  It removes constraints on the
> formatting of tags in the result line (you can even leave them out
> entirely), it recolors lines when tags change, it adds supports for
> multi-line result formats, and rendering big search buffers should be
> less quadratic (it might even be linear).  Much of this derives from
> having a single object representation of a result (the JSON plist) and
> a simple method for rendering it to the buffer.

Overall this series looks excellent. I have reviewed all the patches
except patch 4/7 (I will need to work out how macros work to review
that) and they seem fine modulo the small comments I have made.

One final comment: I couldn't persuade the defcustom search result to
take a newline symbol to test multiline results. It seems to escape
entries of \n, and I couldn't enter returns (and ^Q return didn't work
either).

It was easy by editing the option in my .emacs file and then seemed to
work as expected.

Best wishes

Mark
>
> [0] 1341870162-17782-1-git-send-email-amdragon@mit.edu
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch