Date: Fri, 12 Feb 2016 11:38:40 -0800
From: "W. Trevor King" <wking@tremily.us>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] test/README: have matching test script file names
Message-ID: <20160212193840.GV4265@odin.tremily.us>
References: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="gkEBo/XPSfx+3zOU"
Content-Disposition: inline
In-Reply-To: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
 url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: list


--gkEBo/XPSfx+3zOU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 12, 2016 at 09:17:00PM +0200, Tomi Ollila wrote:
> +The test system itself requires:
> +
> +  - bash(1) version 4.0 or newer
> +
> +Without bash 4.0+ the tests just refuse to run.

This was surprising to me (obviously I haven't looked at the test
library closely ;), because Git tries to maintain compatiblity with
POSIX [1] and Git is the source of notmuch's test framework [2].  But
it looks like notmuch's fork of the test framework was Bash-specific
=66rom 0d67c52f (notmuch-test: Use named-parameters for generate_message
function, 2010-02-03).  That commit happened before the Git framework,
but we still have the code it added:

    # This is our (bash-specific) magic for doing named parameters         =
                                                                           =
                       =20
    local -A template=3D"($@)"

Carl explicitly motivated the change in his commit message.  +1 to
documenting the requirement explicitly in the README, although users
should have been getting nice error messages since 20018a0c (test:
Emit a friendly error message if run with bash < 4.0, 2010-10-28).

Cheers,
Trevor

[1]: https://git.kernel.org/cgit/git/git.git/tree/Documentation/CodingGuide=
lines?h=3Dv2.7.1
[2]: 0083854 (Copy test framework from Git, 2010-06-10)

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--gkEBo/XPSfx+3zOU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJWvjS+AAoJEAPqygegUbGsBsAQAIcqG/DhfnqMIXtZRzbyAfw8
XswP2r2p3DWB7r9UMiBV2PNbY6epeLl0fMX/1baRdrb5QZlfLrews4A0ctOvGMle
WOcxL2GFx37b2yzJ3iQcEbZ49E7Ns/0hmKPS6eD6NXVksMr0ujGNPowbUBC8qJ0c
lCPmwcQIDCCZxAB9smhszTYuTjgi84cwS3VfxbrOD0WBbiKD+tCZ/2ghIf2rYpSQ
Ziwm6JLPwalifO3uisjT01YtkbPHd9YMdSIrPH5giMcEUuXA2Mk2D0BYpPmiiX+g
VZjUEcYES4ko1IyhMlzQcxFoEqIkl6SvZYm2Tn/apHmaCzEZyB9qNTH/+HbhkQwI
XnHqcW4SqmsZN+4meB19FdNdNY/Qe/pLyZLKxpz6enXLt+paahc/Lxv86E86MPCO
Q2OFw6IaobYUCGjPyy1g4OfBj/PCSS0fRc+4fyTGlMip449uIRDGLB4z/0sjYGDn
XIlBUlW6HFpyS5hMjSX3OP0IelEl7hBJUYLJE2AbdpLp1Rfb52e8VJioMPpWFykZ
0Yp1DTb0WiVwwX17mjrUixYKFLBXuQiNejd4j+e39/lFEhQgt/Qc+/Wc45KV348y
m+6IJqc5c45zpdlxWRWQg+Ilplu6fTGjwmPrP/Orahl3adunxsHCL9nxhOwbsOfK
6szdocDPbHY9wZ5HHIct
=ZPVl
-----END PGP SIGNATURE-----

--gkEBo/XPSfx+3zOU--