Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AE3AE431FAF for ; Mon, 17 Dec 2012 04:59:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j0IaD9NbydcJ for ; Mon, 17 Dec 2012 04:59:32 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2F645431FAE for ; Mon, 17 Dec 2012 04:59:32 -0800 (PST) Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.167.90.129] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TkaI4-0000HG-71; Mon, 17 Dec 2012 08:59:28 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TkaHy-0003sZ-ML; Mon, 17 Dec 2012 08:59:22 -0400 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v3 3/5] emacs: show: add invisibility button action In-Reply-To: <1355559338-14313-4-git-send-email-markwalters1009@gmail.com> References: <1355559338-14313-1-git-send-email-markwalters1009@gmail.com> <1355559338-14313-4-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.14+163~g11a220a (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Dec 2012 08:59:22 -0400 Message-ID: <87y5gwx2ad.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 12:59:32 -0000 Mark Walters writes: > This adds a button action to show hidden parts. In this version "t" > toggles the visibility of a part. In addition "RET" on a non-shown > part shows it. After applying this patch (and the two before it), I get emacs-show: Testing emacs notmuch-show view FAIL Hiding Original Message region at beginning of a message --- emacs-show.1.OUTPUT 2012-12-17 12:55:01.000000000 +0000 +++ emacs-show.1.EXPECTED 2012-12-17 12:55:01.000000000 +0000 @@ -4,5 +4,3 @@ Date: Fri, 05 Jan 2001 15:43:57 +0000 [ 2-line hidden original message. Click/Enter to show. ] ------Original Message----- -Text here. nil I believe this failure exists after applying the full series; I'm just double checking now. The problem seems to be specific to emacs24; I'm running 24.2.1 d