Date: Sun, 13 Dec 2015 19:09:46 +0000
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: hello: display jump key next to saved search when
 available
Message-ID: <20151213190946.GA4520@embecosm.com>
References: <1450031043-24038-1-git-send-email-jani@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450031043-24038-1-git-send-email-jani@nikula.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: list

* Jani Nikula <jani@nikula.org> [2015-12-13 20:24:03 +0200]:

> Display the shortcut jump key next to the saved search name in notmuch
> hello, if one is defined for the saved search.
> 
> ---
> 
> This is probably something with infinite bikeshedding
> potential. Therefore I just quickly hacked something together as a
> proof of concept. This displays the jump keys like this:
> 
> 	154 Inbox [j i]
> 
> Maybe the space between "j" and the key is unnecessary? Maybe the "j"
> itself is unnecessary? Maybe the brackets are unnecessary? Maybe it
> could use some color? Does displaying these need to be customizable?
> Etc?
> ---
>  emacs/notmuch-hello.el | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 738baad23b20..3c5440331669 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -578,7 +578,9 @@ with `notmuch-hello-query-counts'."
>  				     (oldest-first t)
>  				     (otherwise notmuch-search-oldest-first)))
>  		     (search-type (eq (plist-get elem :search-type) 'tree))
> -		     (msg-count (plist-get elem :count)))
> +		     (msg-count (plist-get elem :count))
> +		     (key (plist-get elem :key))
> +		     (shortcut (if key (format " [j %s]" key) nil)))

You should probably make use of `substitute-command-key' instead of
hard-coding the "j", something like (untested):

    (format (substitute-command-key " [\[notmuch-jump-search] %s]") key)

Thanks,
Andrew