From: Jani Nikula <jani@nikula.org>
To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions)
In-Reply-To: <1354632382-15609-1-git-send-email-craven@gmx.net>
References: <1354264143-30173-1-git-send-email-craven@gmx.net>
	<1354632382-15609-1-git-send-email-craven@gmx.net>
User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Tue, 04 Dec 2012 19:07:46 +0200
Message-ID: <87boe9lp99.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi Peter -

On Tue, 04 Dec 2012, Peter Feigl <craven@gmx.net> wrote:
> This patch series adds a new output format "sexp" to notmuch-reply,
> notmuch-show and notmuch-search. These are useful for the Android mobile
> client and perhaps other Lisp programs as well.
> After the switch to a generic structured output printer, which was
> committed some months ago, these patches just add another one (like the
> json structured output printer).
> Basic tests and updates to the man pages are also included.
>
>
> Peter Feigl (5):
>   Adding an S-expression structured output printer.
>   Rename the -json printer functions in notmuch-reply and    
>     notmuch-show to generic -sprinter functions.
>   Use the S-Expression structured printer in notmuch-show,
>     notmuch-reply     and notmuch-search.

Patches 1-3 look good.

>   Adding tests for --format=sexp.

Did not review.

>   Updating man pages for new S-Expression output format.

Did not review, but noticed it adds lines with trailing whitespace.


BR,
Jani.


>
>  Makefile.local            |   1 +
>  man/man1/notmuch-reply.1  |  14 ++-
>  man/man1/notmuch-search.1 |  15 +--
>  man/man1/notmuch-show.1   |  36 +++++--
>  notmuch-client.h          |   8 +-
>  notmuch-reply.c           |  43 ++++----
>  notmuch-search.c          |   6 +-
>  notmuch-show.c            |  48 +++++----
>  sprinter-sexp.c           | 250 ++++++++++++++++++++++++++++++++++++++++++++++
>  sprinter.h                |   4 +
>  test/notmuch-test         |   1 +
>  test/sexp                 |  48 +++++++++
>  12 files changed, 414 insertions(+), 60 deletions(-)
>  create mode 100644 sprinter-sexp.c
>  create mode 100755 test/sexp
>
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch