Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2A4A4431FC2 for ; Sun, 9 Feb 2014 04:53:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2g5ujCO+fEYv for ; Sun, 9 Feb 2014 04:53:50 -0800 (PST) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2E282431FBD for ; Sun, 9 Feb 2014 04:53:50 -0800 (PST) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1WCTtC-0000Ld-Iq; Sun, 09 Feb 2014 08:53:38 -0400 Received: (nullmailer pid 27173 invoked by uid 1000); Sun, 09 Feb 2014 12:53:35 -0000 From: David Bremner To: Mark Walters , "W. Trevor King" Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons In-Reply-To: <878utkd2bj.fsf@qmul.ac.uk> References: <877g9chbay.fsf@qmul.ac.uk> <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us> <87vbwwosuw.fsf@qmul.ac.uk> <20140203203418.GO14197@odin.tremily.us> <20140204013246.GQ19935@odin.tremily.us> <87r47dojbt.fsf@zancas.localnet> <20140208165931.GB17142@odin.tremily.us> <878utkd2bj.fsf@qmul.ac.uk> User-Agent: Notmuch/0.17+53~g3e1d7f6 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sun, 09 Feb 2014 08:53:35 -0400 Message-ID: <871tzco3ao.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Feb 2014 12:53:55 -0000 Mark Walters writes: > Looking at the code for that pathway we use > g_mime_message_get_recipients followed by > internet_address_list_to_string and we only output a cc: pair if this is > non-null (which means we had an address) > > In light of that I think changing the cli to only output > content-description if non-null seems consistent. > OK, I can live with it. Thanks for the analysis Mark. Cheers, d