From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Felix Geller <fgeller@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Added variable to toggle message indendation in
	Emacs' notmuch-show
In-Reply-To: <1311015465-8136-1-git-send-email-fgeller@gmail.com>
References: <874o2j4f1e.fsf@servo.factory.finestructure.net>
	<1311015465-8136-1-git-send-email-fgeller@gmail.com>
User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 18 Jul 2011 12:14:29 -0700
Message-ID: <87vcuz2yga.fsf@servo.factory.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

Hi, Felix.  Thanks for resubmitting these patches.  A couple more
comments:

Remember to include a longer log message with you patch.  Beyond just
the single line commit message, the patch should also include a longer
commit message, separated from the first line by a blank line, that
explains what exactly the patch is doing and why.

We've also been trying to get in the habit of sending patches to the
test suite *first*, before the patch that actually implements the
change.  The reason being that we can apply the test-suite patch first,
see that the feature or bug fix you're trying to implement is not
implemented, then apply the fix and see that everything is working
again.

Now is probably a good time to remind everyone to look at the GIT patch
submission guidlines, which notmuch has been trying to follow (also
linked from http://notmuchmail.org):

http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOJIYWAAoJEO00zqvie6q8pBQQAKZxkUqPuEb6dWZZlv3Ylih6
tSU9+yEk/ZsfcG8nOR2J5wwTES0KQEDPcMZS3ZsEZmJ52sXOzEhdLgsawQswcq0j
HVmsUtz4j0Ar6AqBIwrm9wTUVu9uwZTogqEessv8M81anL+hEi5AkpVSnQ8kb8WZ
Wv+ktgKe/zKVBo6DWmT1USiO7pRQ5qQGtGtw0qRWgrWbhH9p9hwaJTQB6/PzB0P7
gVLADuPgg+xSVC0dtiJnEeJaq/m8tfPUtdD/RY67qMlyRYgAHpI3TBv6iEcV3z9v
i98P2AYVmZDwwZEiNKMqB2iPnWo3VYDqAzKeHG6a4hMixmZT340JBr3xyNiMlZgw
Kh/dxDB28fJr5EkGzTJEUYhzdrq3NyrxVcfTb8tf4gDx+/cmHgxq6eIczrCiCTfT
7S/oM2rrDMb4+zE8bUcg5EQIv5b6dsCti3EQxHF3w9qntxYKa91tw9wc8Sbm+q1l
/0UEt0L2D8YZrk8KXpzs6kZjDqmsViA6r94VTYxRZfNGOYOMNiSKjKOh+cBMBhVA
/31yIFK1haXID70x77/KYwdOXZgjYZz5vKy0Si398tJB1JdH8ZrU3HE9B7pq6+49
MYIZSurE7rt9tA6FmNe9IlLltgEwcNCt71yM0H/zDIvciYm0S/pJ4bKWkO3oeM6q
OEVUsuBKPG/dFGUgqsq8
=9ctG
-----END PGP SIGNATURE-----
--=-=-=--