Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5F9CF431FB6 for ; Mon, 31 Dec 2012 08:52:39 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lUGUh3hMXMce for ; Mon, 31 Dec 2012 08:52:38 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DFC01431FAF for ; Mon, 31 Dec 2012 08:52:38 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1TpibJ-0004sa-K4; Mon, 31 Dec 2012 12:52:33 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TpibD-0000V9-RE; Mon, 31 Dec 2012 12:52:27 -0400 From: David Bremner To: Mark Walters , Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v4 4/5] dump/restore: Use Xapian queries for batch-tag format In-Reply-To: <87zk0utmv2.fsf@qmul.ac.uk> References: <1356936162-2589-1-git-send-email-amdragon@mit.edu> <1356936162-2589-5-git-send-email-amdragon@mit.edu> <87zk0utmv2.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14+229~g5a1b22e (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Mon, 31 Dec 2012 12:52:27 -0400 Message-ID: <878v8ekvuc.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 16:52:39 -0000 Mark Walters writes: > One other thing that is noticeable from the errors is that most of the > rest of the errors are very informative but the parse_boolean_term one > is relatively uninformative: it just says we cannot parse the id even > though we know rather more about what the error is (trailing text, no > closing quote, illegal character in an unquoted id etc). I am happy with > it how it is but perhaps David Bremner might like to comment? I don't see a simple way to report better errors without adding more status values to parse_boolean_term; in the other cases we report the error as it is detected, in the cli code. I also don't think it's correct for routines in ./util to directly print error messages. d