Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EFC10429E21 for ; Thu, 17 Nov 2011 01:14:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0S1GTbwBOQ95 for ; Thu, 17 Nov 2011 01:14:15 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 781C1431FD0 for ; Thu, 17 Nov 2011 01:14:15 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id DA1992E50E88; Thu, 17 Nov 2011 01:14:12 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-136-149.socal.res.rr.com [76.174.136.149]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 245C32E50D51; Thu, 17 Nov 2011 01:14:10 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 7FD2DACC; Thu, 17 Nov 2011 01:14:09 -0800 (PST) From: Jameson Graef Rollins To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 0/9] test: (hopefully) better test prerequisites In-Reply-To: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.9+81~gd8cf814 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 17 Nov 2011 01:14:07 -0800 Message-ID: <874ny36rhc.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 09:14:16 -0000 --=-=-= On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin wrote: > The following patch series is an attempt to introduce proper > dependencies for external binaries in a less intrusive way than > [1]. The primary aim was to avoid changing every subtest that > uses external binaries. Hey, Dmitry. Thanks so much for reworking Pieter's original test suite improvements. I think this new approach is a bit less invasive and a little more elegant to work with. I've looked through the patchs, and they all look ok on first glance (barring any possibly needed modifications that I'm not seeing). I have a couple of comments to follow. However, when I tried to test the tests with the patch applied I ran into one problem. If I try to run the test suite with dtach uninstalled, it looks like I'm experiencing a hang on emacs_deliver_message call. I wonder if either emacs_deliver_message or test_emacs is not doing the right thing in the case of no dtach. I think emacs_deliver_message should somehow not require dtach, since it's not actually testing any display stuff, but because it's currently using test_emacs, it is somehow implicitly depending on it. Any thoughts on how to fix that? jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOxNBfAAoJEO00zqvie6q86PAQAJRZpO3D+gTIQiYs+hFB68kr sORqDuHpmg5r+wVwgXdXPoMXYS9oaifv4/UT1LmVLAMsDXfNfwYUeC0PPy0bS2wb 0nVyBsOSmdakJ2UfcULBf08hA2oksuvP/yUR4+nAHKl1j9YOOgHWlpbzwAosTG2j WCfd4Hp5AlcHrYr0RNgC+5qH3lm3jceKoyHqy9ysHr4itlGxQbMPdkkvV82hN7Sr hIxSmvm8ngm9F+UoZjyieOnoBEjZZ5fu3JlsEupNSr0aKkoEb0sFTRabKNfgG8+E D3mpZJAB17QPFkJ4T01iDjHIpB1/mDt7D+ChMCdocdBnDz9NEMIWoPIjgjrIvHsk kf2v6+HJep2uwkT+9tIy9xJ2CcL98IQ40AHx7WWK/QzJeCFzNjDMRyva6ZoddGTx mLKbGU0SpOjWO3GvdA9pSAhiBxNHGt9rzyvA8VUqzRYZUlg3feA3feUe8Xm3Hm4o REbHhYaqWBIDypcjJqbsrV7q6A36ZIY55RaIY2PdiRnxhutzZ9Qk0oCk9dTlCkwr mhOKZbtB7mha7DUdcKW1LIBZszkOJORaM0kFJZEyCV7DcdVa3XqXQhjd3cYRpSJf S7RATqDR1YB2/YEnrs0F/xYREerSIQjiKbmsP61Fbcz7UesoF48k9uZ9aq9VTeyC WME6qrienfq7980SjzUw =Vqhx -----END PGP SIGNATURE----- --=-=-=--