From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH v2 13/13] NEWS: document Emacs UI tagging operations
	changes
In-Reply-To: <20120130050402.GP17991@mit.edu>
References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1327890382-548-14-git-send-email-dmitry.kurochkin@gmail.com>
	<20120130050402.GP17991@mit.edu>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 30 Jan 2012 09:16:28 +0400
Message-ID: <87mx9522j7.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jan 30 at  6:26 am:
> > ---
> >  NEWS |   18 ++++++++++++++++++
> >  1 files changed, 18 insertions(+), 0 deletions(-)
> > 
> > diff --git a/NEWS b/NEWS
> > index 2acdce5..dc3acc4 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -39,6 +39,24 @@ Reply to sender
> >    and search modes, 'r' has been bound to reply to sender, replacing
> >    reply to all, which now has key binding 'R'.
> >  
> > +More robust and consistent tagging operations
> 
> I don't think "robust" is the word you're looking for (same thing with
> some of the commit messages).  In this context, I interpret "robust"
> as meaning "the tagging operations could do incorrect things and have
> been fixed".  Maybe "flexible" or "capable"?
> 

Changed to "flexible".

> > +
> > +  All tagging operations ("+", "-", "*") now accept multiple tags with
> > +  "+" or "-" prefix, like "*" operation in notmuch-search view before.
> 
> Isn't this functionality of * also new in 0.12?
> 

No, "*" in notmuch-search was always working this way.

> > +
> > +  "*" operation (`notmuch-show-tag-all`) is now available in
> 
> Did you mean ' instead of ` at the end?
> 

No.

Regards,
  Dmitry

> > +  notmuch-show view.
> > +
> > +  `Notmuch-show-{add,remove}-tag' functions no longer accept tag
> > +  argument, `notmuch-show-tag-message' should be used instead.  Custom
> > +  bindings using these functions should be updated, e.g.:
> > +
> > +    (notmuch-show-remove-tag "unread")
> > +
> > +  should be changed to:
> > +
> > +    (notmuch-show-tag-message "-unread")
> > +
> >  Library changes
> >  ---------------
> >