From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.
In-Reply-To: <cunobu2pfc4.fsf@hotblack-desiato.hh.sledj.net>
References: <87pqei327k.fsf@gmail.com>
	<1326809224-22673-1-git-send-email-dme@dme.org>
	<1326809224-22673-2-git-send-email-dme@dme.org>
	<877h0qxv4u.fsf@gmail.com>
	<cunobu2pfc4.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+73~g8a5402e (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 17 Jan 2012 18:43:22 +0400
Message-ID: <8739bexud1.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 17 Jan 2012 14:35:07 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 17 Jan 2012 18:26:41 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Sorry, I still do not understand why we can not implement
> > test_emacs_expect_t() like:
> > 
> >   result=${test_emacs $@}
> >   test_expect_equal $result t
> > 
> > Can you please explain?
> 
> In the failure case test_expect_equal does:
> 
>   test_failure_ "$test_subtest_name" "$(diff -u $testname.expected $testname.output)"
> 
> that diff output is not useful here, because the test harness doesn't
> have any expected output other than `t' with which to diff the actual
> output.
> 
> The emacs-address-cleaning test shows how we will provide expected
> vs. actual output directly from within emacs, making it easier for the
> developer to figure out what went wrong.

Thanks for the explanation.

Regards,
  Dmitry