From: Aaron Ecay <aaronecay@gmail.com>
To: David Bremner <david@tethera.net>,
	Jameson Graef Rollins <jrollins@finestructure.net>,
	Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 1/4] emacs: Let the user choose where to compose new
	mails
In-Reply-To: <87r505iecz.fsf@zancas.localnet>
References: <87d3cx2t38.fsf@rocinante.cs.unb.ca>
	<1323797532-597-1-git-send-email-schnouki@schnouki.net>
	<1323797532-597-2-git-send-email-schnouki@schnouki.net>
	<877h1y13dv.fsf@zancas.localnet>
	<87sjklzrcn.fsf@servo.finestructure.net>
	<87r505iecz.fsf@zancas.localnet>
User-Agent: Notmuch/0.10.1+56~gd709fd6 (http://notmuchmail.org)
	Emacs/24.0.92.3 (i386-apple-darwin10.8.0)
Date: Sun, 25 Dec 2011 23:54:41 -0500
Message-ID: <m2ty4oszji.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Thu, 15 Dec 2011 19:50:36 -0400, David Bremner <david@tethera.net> wrote:
> I think the problem is related to emacsclient.
>=20
> With 'm' I have the following behaviour:
>=20
> emacs -q --daemon
> M-x notmuch (to load variable definitions)
> M-x customize-variable notmuch-mua-compose-in
> (select compose in new window, save for current session)
> M-x notmuch
> m               ;; new window is opened as it should be
> C-c C-c         ;; frame is closed.

I just tried, and I cannot reproduce this behavior.  IIUC, here is what
happened to you: you set nm-mua-compose-in to 'new-window.  You began a
new message, this opened a new window as expected.  Your emacs frame now
has two windows in it.  You sent this message, which deleted the window
showing it.  Your emacs frame was deleted as well, which made the other
window, showing notmuch-hello (or some other notmuch buffer, from which
you began writing the email message) disappear as well, unexpectedly.
Is this a correct description of what happened?

Here=E2=80=99s the recipe I used for replicating:

emacs -q --daemon
emacsclient -c
C-x b *scratch*
(add-to-list 'load-path "/path/to/notmuch/emacs/") C-j
(load-library "notmuch") C-j
C-x C-f /path/to/notmuch/emacs/notmuch-mua.el
M-x eval-buffer (in order to pick up changes not in byte-compiled file)
M-x customize-variable notmuch-mua-compose-in (set to 'new-window, save for=
 session)
M-x notmuch
m (new window is created in current frame, below the window showing notmuch=
-hello)
(type mail)
C-c C-c (enter smtp settings, since emacs doesn=E2=80=99t know them)
(new window disappears, the window with notmuch-hello fills whole frame)

I also tried with notmuch-mua-compose-in set to 'new-frame, and got the
expected behavior (m -> create new frame, C-c C-c -> new frame is
deleted)

What version of emacs did you have this problem with?  The window/frame
handling code has undergone several intrusive rewrites post-v.23, each
of which fixed some bugs and introduced others.  The version I used is a
trunk build from Dec. 12-ish.  It would be nice to pinpoint which emacs
versions/configurations show undesired behavior =E2=80=93 this is a useful =
patch
and it should be included once we can be sure it will work correctly.

Thanks,

--=20
Aaron Ecay