From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Escape message ID queries in Emacs
In-Reply-To: <m2sjgutuck.fsf@guru.guru-group.fi>
References: <1332812236-20387-1-git-send-email-amdragon@mit.edu>
	<m2sjgutuck.fsf@guru.guru-group.fi>User-Agent:
	Notmuch/0.12+68~g2b97293 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 27 Mar 2012 03:01:52 -0400
Message-ID: <87aa32h6hr.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 27 Mar 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, Mar 27 2012, Austin Clements wrote:
>
>> Currently, Emacs does not escape message ID queries and is
>> inconsistent about quoting them.  This patch centralizes this in one
>> function that always produces a properly quoted and escaped message ID
>> query.
>>
>> With this, Emacs no longer gets confused by Tomi's crazy message,
>>   id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi"""
>
> LGTM. Things work!
>
>
> One observation, though:
>
> In search bar the following queries return one match:
>
> id:id:"1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi"
> id:"id:""1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi"""
>
> but
>
> id:"id:"1332281811-24710-2b-git-send-email-tomi.ollila@iki.fi""
>
> return 0 matches.
>
> It looks like the (above) search strings goes verbatim to command line
>
> i.e. 'notmuch' 'search' '--sort=oldest-first' 'id:...'
>
> can be used to compare... so that would be CLI issue if there
> is ever need to do do anything with it.

I'm not sure I would consider this a CLI "issue".  It may not be
intuitive, but it is an intentional part of the Xapian query parser's
grammar.  If a boolean prefix is followed immediately by a quote, then
the term is between that quote and the next quote, modulo an escaping
rule that lets you include a literal quote in the term by doubling it in
the query string.  Together, these rules let you reliably put anything
in a boolean search term.

> +1
>
> Thanks for fixing this.
>
> Tomi