DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=a2bor8p/H/FqTFJwVXnJ3NJNcu5ZDTnbDL6edriWrHnflC1b+bVAWOXWsVSpV7Is91
	zng2FmH+icHONXOSK2dCYD71q/WxQ8MHV0EfF1DiWr+HPtsZC1aBMg+9RmMMYZRFwk0f
	Ad2x712+myCsmHA8CUlegjBOW73GpOwh1yct0=
MIME-Version: 1.0
Sender: amdragon@gmail.com
In-Reply-To: <1307189970-728-1-git-send-email-daniel.schoepe@googlemail.com>
References: <1307189970-728-1-git-send-email-daniel.schoepe@googlemail.com>
Date: Sat, 4 Jun 2011 11:32:15 -0400
Message-ID: <BANLkTimudbqYy8JhGHu67WsOS04mCm0hfA@mail.gmail.com>
Subject: Re: [PATCH] emacs: Tab completion for notmuch-search and
	notmuch-search-filter
From: Austin Clements <amdragon@mit.edu>
To: Daniel Schoepe <daniel.schoepe@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

Nifty!

On Sat, Jun 4, 2011 at 8:19 AM, Daniel Schoepe
<daniel.schoepe@googlemail.com> wrote:
> + =A0 =A0 =A0 =A0(minibuffer-completion-table (completion-table-dynamic
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0`(lambda (s) (notmuch-query-completions
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 (quote ,all-compls) s)))))
> + =A0 =A0;; ^ emulate a closure to avoid recomputing the completion list =
each time

Dynamic scoping is obnoxious, but I think programmed completion is
steeped in the assumption that you'll use it.  This code would be much
simpler if notmuch-query-completions took only `string' and used the
dynamically-bound all-compls (which should probably be renamed
notmuch-completions or something if you do this).  Then this could be
just
  (minibuffer-completion-table (completion-table-dynamic
#'notmuch-query-completions)))
and there'd be no need for quasiquoting, comments, and fake lexical scoping=
.

> +    (define-key keymap (kbd "<tab>") 'minibuffer-complete)

This probably deserves a comment about why you're doing so much work
to avoid completing-read (which I assume is because it also binds SPC,
even if require-match is nil, which is unfortunate).