From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, Michal Sojka <sojkam1@fel.cvut.cz>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to
	filter	out	duplicate addresses
In-Reply-To: <m2zjceueg4.fsf@guru.guru-group.fi>
References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
	<1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
	<87egtqug4t.fsf@qmul.ac.uk> <m2zjceueg4.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Thu, 30 Oct 2014 09:00:13 +0000
Message-ID: <87r3xq9bky.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 30 Oct 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:
>
>> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
>>> This adds an algorithm to filter out duplicate addresses from address
>>> outputs (sender, receivers). The algorithm can be configured with
>>> --filter-by command line option.
>>>
>>> The code here is an extended version of a patch from Jani Nikula.
>>
>> Hi
>>
>> As this is getting into the more controversial bike shedding region I
>> wonder if it would be worth splitting this into 2 patches: the first
>> could do the default dedupe based on name/address and the second could
>> do add the filter-by options. 
>>
>> I think the default deduping is obviously worth doing but I am not sure
>> about the rest. In any case I think the default deduping could go in
>> pre-freeze but I would recommend the rest is left until after.
>
> I can agree with that, but there is one hard thing to resolve: 
> "naming things"(*)
>
> (*) http://martinfowler.com/bliki/TwoHardThings.html
>
> With all rest ignored (sorry no time to work on this in more detail now),
> this default deduping could be done with single argument '--unique'...

In this case I am suggesting that to start with the default deduping is
unconditionally done and that there is no command line argument. We can
decide on other filter options, possibly including a completely
unfiltered list (*), later.

Best wishes

Mark

(*) Personally I don't really see a use case for the unfiltered list but
others may disagree.