From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>, David Edmondson <dme@dme.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/2] emacs: create patch filename from subject for
	inline patch fake parts
In-Reply-To: <87wr9ja5bp.fsf@nikula.org>
References: <1321657368-13872-1-git-send-email-jani@nikula.org>
	<cover.1324849534.git.jani@nikula.org>
	<aa55383e8609a2e0d376744ff3e982fd072c58d6.1324849534.git.jani@nikula.org>
	<cun62h3tu51.fsf@hotblack-desiato.hh.sledj.net>
	<87wr9ja5bp.fsf@nikula.org>
User-Agent: Notmuch/0.10.2+127~g6689686 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 26 Dec 2011 12:38:35 -0800
Message-ID: <8739c7jcfo.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 26 Dec 2011 14:24:42 +0200, Jani Nikula <jani@nikula.org> wrote:
> > Clicking on the button for the part saves the wrong thing, though,
> > because it's not a real MIME part. That looks a bit awkward to fix, so
> > perhaps you could still prefix the name with "inline: " to indicate that
> > it's odd?
>=20
> I'm not sure I follow you here. Could you elaborate what you mean by
> "the wrong thing", please?

Yes, this is a problem/bug with the current behavior of these fake
inline parts, actually.  The button should behave as those it is
representing an actual MIME part of the message.  However, clicking the
button saves the entire part that the fake part is derived from, rather
than just the data in the fake part.  This is countereintuitive and
confusing.

> I don't think the user would want to have an "inline: " prefix in the
> filename that would have to be removed every time. I think that kind of
> defeats the purpose here. Or where exactly are you proposing to have the
> prefix?

It's confusing to have this fake part button look just like a real part
button, without any indication that it's really a fake part, and then to
behave differently as well.  The button needs some indication that it
does not represent a real mime part of the message.  Giving the fake
part a proper filename is fine, but it needs some other indicator that
the part is fake and that the button is not going to behave as expected.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO+NtLAAoJEO00zqvie6q8hXcP/3mNEJ0v6qgHJOYu9+/AnpvN
Qz5nvViB3D7cLirxPMsbfslN81WuLegFPsbscAmElH9e/0PdlL6yp2uisfnGQgF+
NPmy3x7sbmwkU5TutJodwUbjQiTboYuMuu9rVEWie8cFJvBNakrQ+3QAAdOMoUlv
z7EojhLr96g9lApSwwqvQKbUOkDfffgECAqCbvNmSk78tlptnsMeH84ZxqT1IR+t
xcp6FDG48Dyj8BgxihQuPUaDQQWkSBjtlFjbBVIvgx8M8gEvM2nrzvMDito4Ai8l
YI9EaOAGHvf64Kf+n+IEKiLUSLDBEriAQi5xtChzb1wvF8BCrxLn/MyDF532fDTB
R55RjlvoHNmGpcOsorF8+3sseNDnEW/pfdHaZhFxNXS/LGVCBNa8vfwOl1eQIgAa
+yBf9nATcq3Eo0BWH1xU0sdWYmhIbaV/qHIBujHw6YhYHIi4r5AcG1YbD+EESNxE
/SK22180RQL1P63cAmIfu+PwLIHl+ZK43Ini0TDybckQUnsLrAxFcOLRLpJKNdDv
Y63YNjlPgAs7n2csz6GarcRK/s+48eTRijzFIsmiCdnWLkcSJUeX85uCTl3/WzCn
UeSFzxP/BvmIcrT7LA9AQERE77pK3vbJmBsfIvxV95lOayt2QyxE1fICYgIDr0rl
9bblqI8H8trvLnwR4TRV
=DrTZ
-----END PGP SIGNATURE-----
--=-=-=--