From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] emacs: removed 3 duplicate functions from
	notmuch-show.el
In-Reply-To: <1377548517-17130-1-git-send-email-tomi.ollila@iki.fi>
References: <1377548517-17130-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 26 Aug 2013 22:27:57 +0100
Message-ID: <87mwo4dtwi.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: tomi.ollila@iki.fi
Precedence: list


This LGTM +1

Mark

On Mon, 26 Aug 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> notmuch-show.el and notmuch.el had 3 duplicate, identical functions:
> notmuch-foreach-mime-part, notmuch-count-attachments and
> notmuch-save-attachments. Now these functions in notmuch-show.el
> are replaced with declare-functions pointing to "notmuch"(.el).
> ---
>  emacs/notmuch-show.el | 39 +++------------------------------------
>  1 file changed, 3 insertions(+), 36 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 82b70ba..2896aae 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -41,6 +41,9 @@
>  (declare-function notmuch-search-next-thread "notmuch" nil)
>  (declare-function notmuch-search-previous-thread "notmuch" nil)
>  (declare-function notmuch-search-show-thread "notmuch" nil)
> +(declare-function notmuch-foreach-mime-part "notmuch" (function mm-handle))
> +(declare-function notmuch-count-attachments "notmuch" (mm-handle))
> +(declare-function notmuch-save-attachments "notmuch" (mm-handle &optional queryp))
>  
>  (defcustom notmuch-message-headers '("Subject" "To" "Cc" "Date")
>    "Headers that should be shown in a message, in this order.
> @@ -237,42 +240,6 @@ For example, if you wanted to remove an \"unread\" tag and add a
>  				 )))
>       (mm-display-parts (mm-dissect-buffer)))))
>  
> -(defun notmuch-foreach-mime-part (function mm-handle)
> -  (cond ((stringp (car mm-handle))
> -         (dolist (part (cdr mm-handle))
> -           (notmuch-foreach-mime-part function part)))
> -        ((bufferp (car mm-handle))
> -         (funcall function mm-handle))
> -        (t (dolist (part mm-handle)
> -             (notmuch-foreach-mime-part function part)))))
> -
> -(defun notmuch-count-attachments (mm-handle)
> -  (let ((count 0))
> -    (notmuch-foreach-mime-part
> -     (lambda (p)
> -       (let ((disposition (mm-handle-disposition p)))
> -         (and (listp disposition)
> -              (or (equal (car disposition) "attachment")
> -                  (and (equal (car disposition) "inline")
> -                       (assq 'filename disposition)))
> -              (incf count))))
> -     mm-handle)
> -    count))
> -
> -(defun notmuch-save-attachments (mm-handle &optional queryp)
> -  (notmuch-foreach-mime-part
> -   (lambda (p)
> -     (let ((disposition (mm-handle-disposition p)))
> -       (and (listp disposition)
> -            (or (equal (car disposition) "attachment")
> -                (and (equal (car disposition) "inline")
> -                     (assq 'filename disposition)))
> -            (or (not queryp)
> -                (y-or-n-p
> -                 (concat "Save '" (cdr (assq 'filename disposition)) "' ")))
> -            (mm-save-part p))))
> -   mm-handle))
> -
>  (defun notmuch-show-save-attachments ()
>    "Save all attachments from the current message."
>    (interactive)
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch