From: Carl Worth <cworth@cworth.org>
To: Anthony Towns <aj@erisian.com.au>, David Edmondson <dme@dme.org>
Subject: Re: [PATCH] json: Avoid calling strlen(NULL)
In-Reply-To: <h2y87b3a4191004060117v5421db8ejbe3030d0626e7440@mail.gmail.com>
References: <877holavq5.fsf@ut.hh.sledj.net>
	<h2y87b3a4191004060117v5421db8ejbe3030d0626e7440@mail.gmail.com>
Date: Tue, 20 Apr 2010 08:59:52 -0700
Message-ID: <878w8iw1vr.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

> There's already a check in json_quote_chararray for len=3D=3D0, so it
> might be sensible to say:
>=20
>     return (json_quote_chararray (ctx, str, str !=3D NULL ? strlen (str) =
: 0));
>=20
> OTOH, the code in json_quote_array to deal with that does the same
> thing (returns a literal string containing two quote marks), which
> seems wrong -- the normal code path is to talloc to get a newly
> allocated, editable string, that might be talloc_free'd later,
> wouldn't it make more sense just to let the str=3D=3DNULL / len=3D=3D0
> behaviour fall through into the normal case code?

Yes, that's the correct analysis. Thanks so much.

> commit 5b93a488221b50c02db18d86a550cb3c038c00da
> Author: Anthony <aj@erisian.com.au>
> Date:   Tue Apr 6 18:10:39 2010 +1000
>=20
>     json: Avoid calling strlen(NULL), and always return a newly
>     talloced array.


I've pushed this out now, (separated into two pieces).

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLzc946JDdNq8qSWgRAsP1AJ9fgpBe6+hZRrq8FRJV3l50kzpv8QCfcal/
i0IWzEcB2C/hBqtiZ3VIu2Q=
=N51E
-----END PGP SIGNATURE-----
--=-=-=--