Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id D757C431E64
	for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:11:01 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id kEzsPJhZedWo for <notmuch@notmuchmail.org>;
	Mon, 30 Jan 2012 06:11:01 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 6E068431FBC
	for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:11:01 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id AC7AD68056; Mon, 30 Jan 2012 16:11:03 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at
	beginning of buffer
In-Reply-To: <1327926286-16680-3-git-send-email-dmitry.kurochkin@gmail.com>
References: <1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1327926286-16680-3-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.11+129~g3b527ae (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 30 Jan 2012 16:11:03 +0200
Message-ID: <m2bopl9t6w.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2012 14:11:02 -0000

On Mon, 30 Jan 2012 16:24:46 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> `Notmuch-wash-region-to-button' is the function that creates hidden
> regions with buttons for signatures, citations and original messages.
> Before the change, it did not work correctly if the to-be-hidden
> region started at the beginning of a message: the visibility toggle
> button was hidden as well.  The patch fixes this.  There are two parts
> in the fix:
> 
> * Use `insert-before-markers' instead of `insert' for creating the
>   button, so that it does not get added to the hidden overlay.
> 
> * Stop using PREFIX argument for adding a newline before the button.
>   The newline should not be added before a button at the beginning of
>   buffer.
> 
> The corresponding test is fixed now.
> ---

+1 -- for test and fix.


Tomi