Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E2D3840DF1F for ; Sat, 20 Nov 2010 15:26:44 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ByTQjXDUtIaW for ; Sat, 20 Nov 2010 15:26:34 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 4AA8740DEEC for ; Sat, 20 Nov 2010 15:26:34 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id A362819F3352; Sun, 21 Nov 2010 00:26:33 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id ZQ4vWBgnCS4Z; Sun, 21 Nov 2010 00:26:32 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id 239C019F334B; Sun, 21 Nov 2010 00:26:32 +0100 (CET) Received: from wsheee.2x.cz (unknown [213.29.198.144]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 1F92AFA004; Sun, 21 Nov 2010 00:26:32 +0100 (CET) Received: from wsh by wsheee.2x.cz with local (Exim 4.72) (envelope-from ) id 1PJwpD-0000NT-Ie; Sun, 21 Nov 2010 00:26:31 +0100 From: Michal Sojka To: meskio@sindominio.net, notmuch@notmuchmail.org Subject: Re: [PATCH] Including 'unread' tag to mails without maildir flags In-Reply-To: <1290181264-5900-1-git-send-email-meskio@sindominio.net> References: <20101118153744.GE3049@blackspot> <1290181264-5900-1-git-send-email-meskio@sindominio.net> User-Agent: Notmuch/0.5-11-g48b5e00 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Sun, 21 Nov 2010 00:26:31 +0100 Message-ID: <87pqtzk254.fsf@wsheee.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Nov 2010 23:26:45 -0000 On Fri, 19 Nov 2010, meskio@sindominio.net wrote: > Some mail fetchers, like fetchmail, leaves the email without ':2,' at the end of > the filename. Notmuch didn't detect this emails as maildir, it didn't add the > maildir flags to them. > > Now it detects if a mail is in a maildir by the directory structure, and add its > maildir flags correctly. Hi Ruben, your patch fixes the problem, but it also breaks one of the tests in test suite. I created the test for your patch and attempted to fix the broken test. See the replies to this message. -Michal