To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] emacs: use a single history for all searches
In-Reply-To: <1326828850-8519-2-git-send-email-dmitry.kurochkin@gmail.com>
References: <1326828850-8519-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1326828850-8519-2-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Wed, 18 Jan 2012 08:25:22 +0000
Message-ID: <cuny5t5mn7x.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 17 Jan 2012 23:34:09 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> There are two ways to do search in Emacs UI: search widget in
> notmuch-hello buffer and `notmuch-search' function bound to "s".
> Before the change, these search mechanisms used different history
> lists.  The patch makes notmuch-hello search use the same history list
> as `notmuch-search' function.

The test output updates included here should be with the previous patch,
shouldn't they?

> -(defun notmuch-search (query &optional oldest-first target-thread target=
-line continuation)
> -  "Run \"notmuch search\" with the given query string and display result=
s.
> +(defun notmuch-search (&optional query oldest-first target-thread target=
-line continuation)
> +  "Run \"notmuch search\" with the given `query' and display results.
>=20=20
> -The optional parameters are used as follows:
> +If `query' is nil, it is read interactively from the minibuffer.
> +Other optional parameters are used as follows:
>=20=20
>    oldest-first: A Boolean controlling the sort order of returned threads
>    target-thread: A thread ID (with the thread: prefix) that will be made
>                   current if it appears in the search results.
>    target-line: The line number to move to if the target thread does not
>                 appear in the search results."
> -  (interactive (list (notmuch-read-query "Notmuch search: ")))
> +  (interactive)
> +  (if (null query)
> +      (setq query (notmuch-read-query "Notmuch search: "))
> +    (setq query (notmuch-trim query))
> +    (let ((history-delete-duplicates t))
> +      (add-to-history 'notmuch-search-history query)))

Should user-typed queries be trimmed?

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8WgfIACgkQaezQq/BJZRbYLwCfffPUJlC6tUhKu76bVhHLnU/r
bSQAn2gPV4si8AKGm+P842o+SkfahG1F
=c6L2
-----END PGP SIGNATURE-----
--=-=-=--