Return-Path: <dme@dme.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 0E46F431FC0
	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:21 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2vL-58xIceZ9 for <notmuch@notmuchmail.org>;
	Mon, 12 May 2014 01:55:17 -0700 (PDT)
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
	[74.125.82.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 97040431FBF
	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:17 -0700 (PDT)
Received: by mail-we0-f179.google.com with SMTP id q59so6461798wes.38
	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:to:subject:in-reply-to:references:user-agent
	:from:date:message-id:mime-version:content-type;
	bh=d8L7F8nXrYrZEZJEO9bdWeyaZIxTa7sT/U4ofziFZpA=;
	b=Dx+Q8Ls4uLqxbi1x6g4zQgmflibVkuzzdZQKiT1awDWFmJje+Y/EzFjGShymTJzGmg
	V7lRjolhFGmm1/ApqP1XKD2Rl1MtnK2FQmQEP/fHCF2bVCOZmWp3+3DMH8nDfAuNHZdR
	NZqyiTxoJlHnypP5HDMCUPsgsny70RMZqDic904a31k3fogtA8lb0D10900a2JEKGCoL
	vqJ8J7gPphUwiekK/j88qq9hgY0YVvuN0/igdt3BGT3uiqHEDAClOisp4BAKOj25PRE2
	a3GXe4CxW8NtSOPe144U/dXLFX0dOFf3eTXMr+F6PccXTu/OgRyH5Y1P4OaCc3xDMnsV
	zGiA==
X-Gm-Message-State:
 ALoCoQlGEwONFbvwJDqf64vYbBiR6fWwUUoUPDG8OXFnFId69MkCBsxifFLq78yp/gUkYT1jr5gr
X-Received: by 10.180.206.205 with SMTP id lq13mr14522143wic.11.1399884915024;
 	Mon, 12 May 2014 01:55:15 -0700 (PDT)
Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])
	by mx.google.com with ESMTPSA id z19sm5923848wiu.0.2014.05.12.01.55.12
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Mon, 12 May 2014 01:55:13 -0700 (PDT)
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Improve the cited message included in replies
In-Reply-To: <87mwenzaap.fsf@qmul.ac.uk>
References: <1399482846-25308-1-git-send-email-dme@dme.org>
	<1399530272-11857-1-git-send-email-dme@dme.org>
	<87ha4y8286.fsf@qmul.ac.uk>
	<cunzjinbkfr.fsf@hotblack-desiato.hh.sledj.net>
	<87mwenzaap.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 12 May 2014 09:55:07 +0100
Message-ID: <cunppjjbclw.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 12 May 2014 08:55:21 -0000

--=-=-=
Content-Type: text/plain

On Mon, May 12 2014, Mark Walters wrote:
>>> Secondly, the existing code only includes text sub-parts of the
>>> message. I would think your version might include any sub-parts show is
>>> configured to display, including, say images. (However, in my testing
>>> images didn't seem to be included: I am not sure why.)
>>
>> Eek.
>
> I phrased this badly. I don't want images included: I just couldn't see
> why they weren't with your current patch (as they are displayed in show
> mode)

`buffer-substring-no-properties' grabs the text of the rendered buffer
without any properties, and images are inserted using properties.

You could replace it with `buffer-substring' to see the images in the
reply buffer (but see previous comments about what happens when you
send).

> I guess my concern with adding to the show code is that is already
> more complicated than I would like (invisibility, hidden parts, lazy
> parts etc).

One complex piece of code that knows how to iterate over messages
display the parts seems enough - why have two?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iKYEARECAGYFAlNwjGtfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5
RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRZ5JACfVOJCSqiGwqDy1Po4l1Es6kXA
h4oAnjn/ZpShpSkC9y8cCMH4fTYKuiop
=DGjg
-----END PGP SIGNATURE-----
--=-=-=--